After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699202 - DLL isn't generated by MinGW cross compile on Linux
DLL isn't generated by MinGW cross compile on Linux
Status: RESOLVED FIXED
Product: clutter-gtk
Classification: Platform
Component: general
unspecified
Other Windows
: Normal normal
: ---
Assigned To: clutter-gtk maintainer(s)
clutter-gtk maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-29 09:18 UTC by Kouhei Sutou
Modified: 2014-10-07 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix typos to use -no-undefined ld flag (1.40 KB, patch)
2013-04-29 09:18 UTC, Kouhei Sutou
committed Details | Review

Description Kouhei Sutou 2013-04-29 09:18:31 UTC
Created attachment 242781 [details] [review]
Fix typos to use -no-undefined ld flag

-no-undefined ld flag is required to generate DLL by MinGW cross compile but -no-undefined ld flag isn't used. See the attached patch for details.
Comment 1 Kouhei Sutou 2014-10-07 12:37:57 UTC
I add more explanations.

* CLUTTER_LT_LDFLAGS in configure.ac is a typo. "GTK_" is missing before "LT_LDFLAGS".
* CLUTTER_GTK_LT_LDFLAGS is AC_SUBST()-ed but CLUTTER_LT_LDFLAGS isn't AC_SUBST()-ed. So we can't use CLUTTER_LT_LDFLAGS in Makefile.am.
* clutter-gtk/Makefile.am uses CLUTTER_LT_LDFLAGS (typo) not CLUTTER_GTK_LT_LDFLAGS. But CLUTTER_LT_LDFLAGS isn't AC_SUBST()-ed. So the value is always empty even if "-no-undefined" is specified to CLUTTER_LT_LDFLAGS.

Could you review the patch?
Comment 2 Emmanuele Bassi (:ebassi) 2014-10-07 13:07:07 UTC
thanks for the patch, and sorry for taking this long to push it.