After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699169 - Load More Button doesn't exist in Artist view
Load More Button doesn't exist in Artist view
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-28 19:39 UTC by Eslam Mostafa
Modified: 2013-05-03 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Show load more button in artist view (1.86 KB, patch)
2013-04-29 15:54 UTC, Eslam Mostafa
needs-work Details | Review
The patch shows load more button in the artists view and works correctly (1.94 KB, patch)
2013-04-30 10:52 UTC, Sai Suman Prayaga
needs-work Details | Review
The size of load more button is now consistent with the size of container. (2.45 KB, patch)
2013-05-01 14:51 UTC, Sai Suman Prayaga
accepted-commit_now Details | Review

Description Eslam Mostafa 2013-04-28 19:39:46 UTC
The "Load More" button doesn't show up in Artist view.
Comment 1 Eslam Mostafa 2013-04-29 15:54:20 UTC
Created attachment 242819 [details] [review]
Show load more button in artist view

the load more button shows up in artist view, but it still doesn't load artists.
need to work more on the query maybe.
Comment 2 Sai Suman Prayaga 2013-04-30 10:52:28 UTC
Created attachment 242897 [details] [review]
The patch shows load more button in the  artists view and works correctly

The loadmore button shows up and now loads the artists in the artists view.
Comment 3 Vadim Rutkovsky 2013-04-30 11:19:07 UTC
Review of attachment 242897 [details] [review]:

Load More button is breaking artist column when no artist is selected.
Initial - http://ompldr.org/vaTlweQ
When scrolling down and no artist selected - http://ompldr.org/vaTlweg
Comment 4 Sai Suman Prayaga 2013-05-01 14:51:44 UTC
Created attachment 242998 [details] [review]
The size of load more button is now  consistent with the size of container.
Comment 5 Vadim Rutkovsky 2013-05-02 09:57:19 UTC
Review of attachment 242998 [details] [review]:

Thanks, now works fine, please commit