After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699140 - Baseline support breaks height-for-width in event box
Baseline support breaks height-for-width in event box
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-04-28 14:25 UTC by Tristan Van Berkom
Modified: 2013-05-07 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Labels alone in a grid do height-for-width properly (4.13 KB, text/plain)
2013-04-28 14:25 UTC, Tristan Van Berkom
  Details
Event boxes don't do height-for-width properly anymore (4.84 KB, text/plain)
2013-04-28 14:27 UTC, Tristan Van Berkom
  Details
GtkEventBox: Correctly handle height for width (885 bytes, patch)
2013-05-06 15:49 UTC, Alexander Larsson
committed Details | Review

Description Tristan Van Berkom 2013-04-28 14:25:48 UTC
Created attachment 242713 [details]
Labels alone in a grid do height-for-width properly

I've tracked this down to this commit:

commit 8fbd6e2edc771ca4fa9d63993d3e9f585d3eeeca
Author: Alexander Larsson <alexl@redhat.com>
Date:   Tue Mar 26 11:08:33 2013 +0100

Attaching examples...
Comment 1 Tristan Van Berkom 2013-04-28 14:27:52 UTC
Created attachment 242714 [details]
Event boxes don't do height-for-width properly anymore

This is pretty much the same layout except that the labels are inside event boxes.

To try either tests, run:

  glade-previewer -f event-boxes-dont-wrap-in-grid.glade

or for the working test:

  glade-previewer -f labels-wrap-in-grid.glade
Comment 2 Tristan Van Berkom 2013-04-28 14:54:21 UTC
FWIW, I'm not doing any active regression hunt.

This one was very obvious and stands out in Glade, since we
use a setup like this for our property display labels:

GtkEventBox {
   GtkBox {
      GtkImage (for a possible warning icon),
      GtkLabel (they all wrap)
   }
}

We use an event box in order to display a generic context menu
which allows one to reset the property to default value or read
documentation for the property.
Comment 3 Alexander Larsson 2013-05-06 15:49:59 UTC
Created attachment 243396 [details] [review]
GtkEventBox: Correctly handle height for width

We need to pass on the width to the child.
Comment 4 Alexander Larsson 2013-05-06 15:50:22 UTC
Attachment 243396 [details] pushed as c6a5b80 - GtkEventBox: Correctly handle height for width
Comment 5 Alexander Larsson 2013-05-06 15:50:54 UTC
That was a lame bug, thanks for catching it.
Comment 6 Tristan Van Berkom 2013-05-07 05:30:14 UTC
(In reply to comment #5)
> That was a lame bug, thanks for catching it.

Thankyou for fixing it ! ;-)

Any chance I can get you to also fix GtkCheckButton ?
Comment 7 Alexander Larsson 2013-05-07 13:17:38 UTC
Does it have the same bug?
Comment 8 Alexander Larsson 2013-05-07 13:22:27 UTC
Ah, that has already been fixed by benjamin