GNOME Bugzilla – Bug 699054
Native Window Placement fix: make windowCaptionsOnTop work again
Last modified: 2013-06-08 16:48:10 UTC
On gnome shell 3.8 window captions are always placed below the windows - the windowCaptionsOnTop option has no effect.
Created attachment 242671 [details] [review] Small Patch reducing gnome shell changes This is the first part of the patch. It just makes our functions simpler by using the new gnome shell infrastructure in 3.8.
Created attachment 242672 [details] [review] CaptionsOnTop patch This is the actual patch fixing the CaptionsOnTop issue. Applied on top of the first patch.
Review of attachment 242671 [details] [review]: This looks good for 3.8, but I'm afraid a bigger change or a revert will be needed for 3.9, as realRecalculateWindowPositions() is more integrated into LayoutStrategy.
Review of attachment 242672 [details] [review]: Ok
(In reply to comment #3) > Review of attachment 242671 [details] [review]: > > This looks good for 3.8, but I'm afraid a bigger change or a revert will be > needed for 3.9, as realRecalculateWindowPositions() is more integrated into > LayoutStrategy. Hm - didn't recognize that :-( I won't fix this now since I don't have a working 3.9 version of the gnome-shell running for testing. Can you merge the second patch into the 3.8 branch since the extension is quite unusable without it? ;-)
Both patches merged to gnome-3-8.
Great! Thanks! I'm working on the 3.9 version now. (using this ppa: https://launchpad.net/~ricotz/+archive/testing?field.series_filter=raring)
Created attachment 245406 [details] [review] 3.9 patch This is a quick fix to make it work on gnome-shell 3.9. A better fix would be to implement our own LayoutStrategy class and benefit from the delayed _realRecalculateWindowPositions() functionality. Tried this but wasn't able to make it work reliably. Can deliver the branch if someone is interested in...
Thank you for your patch, it's good enough that I merged it to 3.9. If you want to continue your work and use LayoutStrategy, that's very welcome. Otherwise, I don't think I'll commit much time to this extension...