After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699007 - FoG list of previous donors needs a consistent multicolumn support
FoG list of previous donors needs a consistent multicolumn support
Status: RESOLVED FIXED
Product: website
Classification: Infrastructure
Component: www.gnome.org
current
Other Linux
: Normal normal
: ---
Assigned To: GNOME Web maintainers
GNOME Web maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-27 00:08 UTC by Juanjo Marín
Modified: 2013-11-14 11:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixed bug "FoG list of previous donors needs a consistent multicolumn support" with css columns (1.56 KB, patch)
2013-04-30 22:25 UTC, Bojana
rejected Details | Review
Screenshot of previous donors page (190.37 KB, image/png)
2013-11-13 23:21 UTC, arpita
  Details
FoG list of previous donors with a consistent multicolumn support (1.67 KB, patch)
2013-11-14 10:33 UTC, arpita
none Details | Review
FoG list of previous donors with a consistent multicolumn support. (1.67 KB, patch)
2013-11-14 11:00 UTC, arpita
committed Details | Review

Description Juanjo Marín 2013-04-27 00:08:43 UTC
In http://www.gnome.org/friends/previous-donors/ there are 1,2 and 3 columns of previous donors with different layouts.
Comment 1 Andreas Nilsson 2013-04-27 00:46:26 UTC
Confirmed.
I think the whole thing should be a strict 3 column grid spread out across the whole page width.

I imagine the following structure

2012

Sponsor

Sponsor01       Sponsor05       Sponsor09
Sponsor02       Sponsor06       Sponsor10
Sponsor03       Sponsor07       Sponsor11
Sponsor04       Sponsor08       Sponsor12


Associate

Associate01     Associate05     Associate09
Associate02     Associate06     Associate10
Associate03     Associate07     Associate11
Associate04     Associate08     Associate12


etc.

Best would probably to use css columns
Comment 2 Bojana 2013-04-30 22:25:49 UTC
Created attachment 242970 [details] [review]
Fixed bug "FoG list of previous donors needs a consistent multicolumn support" with css columns
Comment 3 Bojana 2013-05-01 08:53:44 UTC
Comment on attachment 242970 [details] [review]
Fixed bug "FoG list of previous donors needs a consistent multicolumn support" with css columns

>diff -ruN theme_new/page-previous-donors.php theme/page-previous-donors.php
>--- theme_new/page-previous-donors.php	2013-04-30 23:48:33.961267100 +0200
>+++ theme/page-previous-donors.php	2013-04-22 16:26:24.000000000 +0200
>@@ -60,7 +60,7 @@
>                         $level_count = count($donor_array);
>                         if ($level_count > 1) { // The count behaves weirdly for me. Always +1.
>                             echo "<h4>$fname_dispname_map[$level]</h4>\n";
>-                            echo '<ul class="col-3">'."\n";
>+                            echo '<ul style="list-style-type: disc;">'."\n";
>                             foreach ($donor_array as $donor_line) {
>                                 $donor = trim($donor_line, "\x00..\x20");
>                                 if (strlen($donor) > 0)
>diff -ruN theme_new/style.css theme/style.css
>--- theme_new/style.css	2013-04-30 23:47:56.109102100 +0200
>+++ theme/style.css	2013-04-22 16:26:24.000000000 +0200
>@@ -1088,9 +1088,3 @@
> .crm-section {
> 	margin-bottom: 10px;
> }
>-
>-.col-3{
>-    columns:100px 3;
>-    -webkit-columns:100px 3; /* Safari and Chrome */
>-    -moz-columns:100px 3; /* Firefox */
>-}
Comment 4 arpita 2013-11-13 23:21:30 UTC
Created attachment 259766 [details]
Screenshot of previous donors page
Comment 5 Andreas Nilsson 2013-11-14 10:30:46 UTC
Review of attachment 242970 [details] [review]:

Seems to have bitrotted since April, unfortunately. Sorry for the slow review. Totally forgot about this one.
Comment 6 arpita 2013-11-14 10:33:26 UTC
Created attachment 259793 [details] [review]
FoG list of previous donors with a consistent multicolumn support
Comment 7 arpita 2013-11-14 11:00:22 UTC
Created attachment 259794 [details] [review]
FoG list of previous donors with a consistent multicolumn  support.
Comment 8 Andreas Nilsson 2013-11-14 11:07:19 UTC
Review of attachment 259794 [details] [review]:

Looks good.
Committed as https://git.gnome.org/browse/gnome-web-www/commit/?id=bc2e5065610697f007f156e849a646773cb7db3a

Thank you very much for your fix!