GNOME Bugzilla – Bug 699007
FoG list of previous donors needs a consistent multicolumn support
Last modified: 2013-11-14 11:07:35 UTC
In http://www.gnome.org/friends/previous-donors/ there are 1,2 and 3 columns of previous donors with different layouts.
Confirmed. I think the whole thing should be a strict 3 column grid spread out across the whole page width. I imagine the following structure 2012 Sponsor Sponsor01 Sponsor05 Sponsor09 Sponsor02 Sponsor06 Sponsor10 Sponsor03 Sponsor07 Sponsor11 Sponsor04 Sponsor08 Sponsor12 Associate Associate01 Associate05 Associate09 Associate02 Associate06 Associate10 Associate03 Associate07 Associate11 Associate04 Associate08 Associate12 etc. Best would probably to use css columns
Created attachment 242970 [details] [review] Fixed bug "FoG list of previous donors needs a consistent multicolumn support" with css columns
Comment on attachment 242970 [details] [review] Fixed bug "FoG list of previous donors needs a consistent multicolumn support" with css columns >diff -ruN theme_new/page-previous-donors.php theme/page-previous-donors.php >--- theme_new/page-previous-donors.php 2013-04-30 23:48:33.961267100 +0200 >+++ theme/page-previous-donors.php 2013-04-22 16:26:24.000000000 +0200 >@@ -60,7 +60,7 @@ > $level_count = count($donor_array); > if ($level_count > 1) { // The count behaves weirdly for me. Always +1. > echo "<h4>$fname_dispname_map[$level]</h4>\n"; >- echo '<ul class="col-3">'."\n"; >+ echo '<ul style="list-style-type: disc;">'."\n"; > foreach ($donor_array as $donor_line) { > $donor = trim($donor_line, "\x00..\x20"); > if (strlen($donor) > 0) >diff -ruN theme_new/style.css theme/style.css >--- theme_new/style.css 2013-04-30 23:47:56.109102100 +0200 >+++ theme/style.css 2013-04-22 16:26:24.000000000 +0200 >@@ -1088,9 +1088,3 @@ > .crm-section { > margin-bottom: 10px; > } >- >-.col-3{ >- columns:100px 3; >- -webkit-columns:100px 3; /* Safari and Chrome */ >- -moz-columns:100px 3; /* Firefox */ >-}
Created attachment 259766 [details] Screenshot of previous donors page
Review of attachment 242970 [details] [review]: Seems to have bitrotted since April, unfortunately. Sorry for the slow review. Totally forgot about this one.
Created attachment 259793 [details] [review] FoG list of previous donors with a consistent multicolumn support
Created attachment 259794 [details] [review] FoG list of previous donors with a consistent multicolumn support.
Review of attachment 259794 [details] [review]: Looks good. Committed as https://git.gnome.org/browse/gnome-web-www/commit/?id=bc2e5065610697f007f156e849a646773cb7db3a Thank you very much for your fix!