After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699001 - bytesicon: don't use g_object_unref() on GBytes
bytesicon: don't use g_object_unref() on GBytes
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-04-26 21:12 UTC by Cosimo Cecchi
Modified: 2013-04-27 10:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bytesicon: don't use g_object_unref() on GBytes (743 bytes, patch)
2013-04-26 21:12 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-04-26 21:12:37 UTC 
See patch
Comment 1 Cosimo Cecchi 2013-04-26 21:12:39 UTC 
Created attachment 242624 [details] [review]
bytesicon: don't use g_object_unref() on GBytes

We need to use g_bytes_unref()
Comment 2 Allison Karlitskaya (desrt) 2013-04-26 22:15:22 UTC 
Review of attachment 242624 [details] [review]:

lol.  Lars caught this while reviewing it but didn't write it down so I forgot about it.  It's a consequence of GBytesIcon starting life as a copy/paste of GFileIcon (where GFile is a GObject).

Please commit.
Comment 3 Cosimo Cecchi 2013-04-27 10:46:22 UTC 
Attachment 242624 [details] pushed as 706e636 - bytesicon: don't use g_object_unref() on GBytes