After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698981 - [PATCH] test /gdbus/connection/large_message could hang forever
[PATCH] test /gdbus/connection/large_message could hang forever
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.36.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-04-26 17:32 UTC by Josep Puigdemont
Modified: 2013-05-21 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch, test will timeout if dbus name has not appeared after 10 seconds. (2.11 KB, patch)
2013-04-26 17:32 UTC, Josep Puigdemont
reviewed Details | Review
[PATCH] Timeout the test if dbus sevice has not appeared in due time. (2.77 KB, patch)
2013-05-21 14:58 UTC, Josep Puigdemont
committed Details | Review

Description Josep Puigdemont 2013-04-26 17:32:08 UTC
Created attachment 242602 [details] [review]
patch, test will timeout if dbus name has not appeared after 10 seconds.

the test /gdbus/connection/large_message (gio/tests/gdbus-connection-slow.c) waits for a dbus name to appear.
The dbus name is created by a python script executed in a background process. If for some reason the script fails, the test will wait forever.
To avoid this situation the patch provided will make the test fail if the name has not appeared after 10 seconds.
Comment 1 Colin Walters 2013-05-21 13:41:01 UTC
Review of attachment 242602 [details] [review]:

No objections to this patch if you found it useful.  Please do add a link in the commit message back to this bug, per https://live.gnome.org/GnomeLove/SubmittingPatches

::: gio/tests/gdbus-connection-slow.c
@@ +124,3 @@
+  (void)data;
+
+  g_printerr ("Error: timeout waiting for dbus name to appear\n");

Could just use g_error()

@@ +125,3 @@
+
+  g_printerr ("Error: timeout waiting for dbus name to appear\n");
+  g_assert (FALSE == TRUE);

And delete this line then.
Comment 2 Josep Puigdemont 2013-05-21 14:58:12 UTC
Created attachment 244932 [details] [review]
[PATCH] Timeout the test if dbus sevice has not appeared in due time.
Comment 3 Colin Walters 2013-05-21 15:17:33 UTC
Review of attachment 244932 [details] [review]:

Looks good, thanks.