GNOME Bugzilla – Bug 698981
[PATCH] test /gdbus/connection/large_message could hang forever
Last modified: 2013-05-21 15:18:40 UTC
Created attachment 242602 [details] [review] patch, test will timeout if dbus name has not appeared after 10 seconds. the test /gdbus/connection/large_message (gio/tests/gdbus-connection-slow.c) waits for a dbus name to appear. The dbus name is created by a python script executed in a background process. If for some reason the script fails, the test will wait forever. To avoid this situation the patch provided will make the test fail if the name has not appeared after 10 seconds.
Review of attachment 242602 [details] [review]: No objections to this patch if you found it useful. Please do add a link in the commit message back to this bug, per https://live.gnome.org/GnomeLove/SubmittingPatches ::: gio/tests/gdbus-connection-slow.c @@ +124,3 @@ + (void)data; + + g_printerr ("Error: timeout waiting for dbus name to appear\n"); Could just use g_error() @@ +125,3 @@ + + g_printerr ("Error: timeout waiting for dbus name to appear\n"); + g_assert (FALSE == TRUE); And delete this line then.
Created attachment 244932 [details] [review] [PATCH] Timeout the test if dbus sevice has not appeared in due time.
Review of attachment 244932 [details] [review]: Looks good, thanks.