After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698978 - Widget margins are not calculated
Widget margins are not calculated
Status: RESOLVED FIXED
Product: egg-list-box
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: egg-list-box-maint
egg-list-box-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-26 17:11 UTC by Jonh Wendell
Modified: 2013-05-10 00:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Wrong draw (19.31 KB, image/png)
2013-04-26 17:11 UTC, Jonh Wendell 		  Details
Correct draw, after patch (21.70 KB, image/png)
2013-04-26 17:12 UTC, Jonh Wendell 		  Details
test case (1.06 KB, text/x-csrc)
2013-04-26 17:12 UTC, Jonh Wendell 		  Details
proposed patch (3.75 KB, patch)
2013-04-26 17:14 UTC, Jonh Wendell 		rejected Details | Review
proposed patch, v2 (1.33 KB, patch)
2013-05-07 19:16 UTC, Jonh Wendell 		committed Details | Review

Description Jonh Wendell 2013-04-26 17:11:31 UTC 
Created attachment 242597 [details]
Wrong draw

If you set the flowbox's margins you are get wrong draws. I'm attaching the odd screenshot.
Comment 1 Jonh Wendell 2013-04-26 17:12:01 UTC 
Created attachment 242598 [details]
Correct draw, after patch
Comment 2 Jonh Wendell 2013-04-26 17:12:46 UTC 
Created attachment 242599 [details]
test case
Comment 3 Jonh Wendell 2013-04-26 17:14:54 UTC 
Created attachment 242600 [details] [review]
proposed patch
Comment 4 Matthias Clasen 2013-04-29 02:07:07 UTC 
Review of attachment 242600 [details] [review]:

Patch looks wrong to me - widgets should not have to fiddle manually with margins like that. It is all supposed to be taken care of by gtk. We need to find out why thats not working correctly for EggFlowBox
Comment 5 Jonh Wendell 2013-05-07 19:16:26 UTC 
Created attachment 243530 [details] [review]
proposed patch, v2

please, take a look at this approach. it fixed the issue to me.
Comment 6 Tristan Van Berkom 2013-05-09 07:17:33 UTC 
Comment on attachment 243530 [details] [review]
proposed patch, v2

This is correct.

EggWrapBox allocated children this way but it did not have it's own window.

Looks like this bug occurred since now the EggFlowBox owns a window and the child allocation was not updated accordingly.
Comment 7 Jonh Wendell 2013-05-10 00:12:39 UTC 
thanks for reviewing, pushed.