After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698959 - shellDBus: Fix Eval() return value when disabled
shellDBus: Fix Eval() return value when disabled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-26 15:10 UTC by Florian Müllner
Modified: 2013-04-26 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shellDBus: Fix Eval() return value when disabled (1.01 KB, patch)
2013-04-26 15:10 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-04-26 15:10:48 UTC 
See patch.
Comment 1 Florian Müllner 2013-04-26 15:10:52 UTC 
Created attachment 242579 [details] [review]
shellDBus: Fix Eval() return value when disabled

Eval() is expected to return a boolean success value and a string result.
However when the function is disabled (via the development-tools setting),
we return null for the latter which is not a valid string value.
Return an empty string instead.
Comment 2 Giovanni Campagna 2013-04-26 15:17:50 UTC 
Review of attachment 242579 [details] [review]:

Yes.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-04-26 15:18:02 UTC 
Review of attachment 242579 [details] [review]:

Was this causing the hang for that guy on G+? OK.
Comment 4 Florian Müllner 2013-04-26 15:55:22 UTC 
Attachment 242579 [details] pushed as 39426f0 - shellDBus: Fix Eval() return value when disabled