GNOME Bugzilla – Bug 698929
Remove deprecated call to gdk_display_get_n_screens
Last modified: 2013-05-15 08:04:46 UTC
There is a call to this function in wacom and other plugins. If you want, I can provide patches to fix all of them as this is pretty simple.
Created attachment 242528 [details] [review] wacom: Remove deprecated call to gdk_display_get_n_screens Also skips using the display to get the default screen.
Review of attachment 242528 [details] [review]: ::: plugins/wacom/gsd-wacom-manager.c @@ +1419,3 @@ + return; + } + manager->priv->screens = g_slist_append (manager->priv->screens, screen); why do we keep lists if there's only ever going to be one member? @@ +1432,2 @@ } + manager->priv->rr_screens = g_list_prepend (manager->priv->rr_screens, rr_screen); Ditto.
Created attachment 242914 [details] [review] wacom: Remove deprecated call to gdk_display_get_n_screens Hadn't noticed the GLists... Updated patch.
Review of attachment 242914 [details] [review]: ::: plugins/common/gsd-keygrab.h @@ -51,3 @@ void grab_button (int deviceid, gboolean grab, - GSList *screens); Can you please re-indent? ::: plugins/wacom/gsd-wacom-manager.c @@ +1419,3 @@ + + /* + * We also keep a list of GnomeRRScreen to monitor changes such as rotation We don't...
Created attachment 244155 [details] [review] wacom: Remove deprecated call to gdk_display_get_n_screens New version addressing the latest comments.
Review of attachment 244155 [details] [review]: Feel free to commit after that. ::: plugins/wacom/gsd-wacom-manager.c @@ +1533,3 @@ } + if (wacom_manager->priv->rr_screen != NULL) { g_clear_object();
Pushed with the last comment's changes.