GNOME Bugzilla – Bug 698890
warning: Folks doesn't set GIR namespace or version annotation
Last modified: 2013-06-24 16:14:55 UTC
I'm not sure how I haven't noticed this earlier, but I just got this build warning: folks.vapi:3.1-3.15: warning: Namespace Folks does not have a GIR namespace and version annotation namespace Folks { ^^^^^^^^^^^^^^^ This should be fixable by just setting the various *_gir_NAMESPACE, *_gir_VERSION, etc. magic constants in folks/Makefile.am. See how it's done in telepathy-glib/introspection.am
I can’t reproduce this. What GIR and Vala versions are you using? (I’m using GIR 3ec52d61 and Vala e5608074.)
g-ir: 1.37.1 vala: 0.20.1.30-1b1d
Created attachment 247086 [details] [review] Set the GIR version in the namespace (which appears in folks.vapi) This is apparently how this is supposed to be set (and how Gee does it). I didn't notice at the time - the warning happens when building a /client/ of Folks, not Folks itself.
Review of attachment 247086 [details] [review]: Looks good to me. I’d be fine with this being committed once you’ve added a comment. Don’t forget to add it to NEWS. ::: folks/folks-namespace.vala @@ +19,3 @@ + */ + +[CCode (gir_namespace = "Folks", gir_version = "0.6")] Might want to add a comment explaining what the purpose of the file is.
Include GIR version number in folks.vapi The fact that this was missing was causing build warnings for all clients Bug: https://bugzilla.gnome.org/show_bug.cgi?id=698890 NEWS | 1 + folks/Makefile.am | 1 + folks/folks-namespace.vala | 29 +++++++++++++++++++++++++++++ 3 files changed, 31 insertions(+)