GNOME Bugzilla – Bug 698831
Move loading an ui file to an util
Last modified: 2013-08-31 03:08:11 UTC
Loading from a resource cannot fail, so hide the try/catch in an util. Also remove the custom vapi and setting the translation domain since they are not needed anymore.
Created attachment 242405 [details] [review] Move loading an ui file to an util
Created attachment 242406 [details] [review] Use an .ui file for the new contact dialog
More cleanup is possible by using GtkMenuButton (and putting it in the ui file) instead of ContactsMenuButton, but it is not clear to me if ContactsMenuButton exists because it does something different or of it just predates the Gtk widget
Review of attachment 242406 [details] [review]: I forgot to add the file to POTFILES.in, I'll do that if the patch is ok
Created attachment 242411 [details] [review] Use an .ui file for the new contact dialog
Created attachment 242412 [details] [review] Use GtkMenuButton instead of a custom widget
(In reply to comment #3) > More cleanup is possible by using GtkMenuButton (and putting it in the ui file) > instead of ContactsMenuButton, but it is not clear to me if ContactsMenuButton > exists because it does something different or of it just predates the Gtk > widget The ContactsMenuButton exist before GtkMenuButton, so I'll check but Ithink is a safe replace.
(In reply to comment #0) > Loading from a resource cannot fail, so hide the try/catch in an util. > Also remove the custom vapi and setting the translation domain since > they are not needed anymore. This one is pushed here: https://git.gnome.org/browse/gnome-contacts/commit/?id=bcb610d1190576b1c98d241b80e910c81515ca62 About the other two I prefer Alex to review those since it's his code in the new-contact dialog. Also I would ask Allan cause I think I remember we're dropping the new-contact dialog for in-place new-contact behavior. But again. I'll ask Alex to review the other to. I'm marking this patch obsolete as is already pushed.
Comment on attachment 242405 [details] [review] Move loading an ui file to an util It turned out there was a committed state.
Comment on attachment 242412 [details] [review] Use GtkMenuButton instead of a custom widget Pushed the migration, but not using the ui file.
Comment on attachment 242405 [details] [review] Move loading an ui file to an util As eventually we will move to in-place contact creation.
Closed as fixed because I couldn't find category for both fixed and not-fixed. I'm closing it because contacts creation inside the application is in the Roadmap, so I'll get rid of this dialog eventually.