After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698826 - v4l2: add support for mpeg4 and H.263
v4l2: add support for mpeg4 and H.263
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-25 10:48 UTC by Michael Olbrich
Modified: 2013-04-26 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.97 KB, patch)
2013-04-25 10:48 UTC, Michael Olbrich 		needs-work Details | Review
updated patch (2.10 KB, patch)
2013-04-26 12:18 UTC, Michael Olbrich 		committed Details | Review

Description Michael Olbrich 2013-04-25 10:48:04 UTC 
Created attachment 242400 [details] [review]
patch

just the mappings for coresponding v4l2 and gstreamer types
Comment 1 Sebastian Dröge (slomo) 2013-04-25 10:51:51 UTC 
Review of attachment 242400 [details] [review]:

::: sys/v4l2/gstv4l2object.c
@@ +1213,3 @@
+#ifdef V4L2_PIX_FMT_MPEG4
+    case V4L2_PIX_FMT_MPEG4:
+      structure = gst_structure_new_empty ("video/mpeg");

This should include mpegversion=4 and systemstream=false

@@ +1218,3 @@
+#ifdef V4L2_PIX_FMT_H263
+    case V4L2_PIX_FMT_H263:
+      structure = gst_structure_new_empty ("video/x-h263");

And this variant=itu
Comment 2 Michael Olbrich 2013-04-26 12:18:13 UTC 
Created attachment 242553 [details] [review]
updated patch

Here is a new patch updated according to the comments
Comment 3 Sebastian Dröge (slomo) 2013-04-26 12:31:11 UTC 
commit 3466796f10790ac305d9b27ec2e9fba00aec67e6
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date:   Tue Jul 10 15:29:40 2012 +0200

    v4l2: add support for mpeg4 and H.263
    
    https://bugzilla.gnome.org/show_bug.cgi?id=698826