Bug 698812 – Gnome shell crashed after lockscreen was unlocked.

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 698812 - Gnome shell crashed after lockscreen was unlocked.


Summary:	Gnome shell crashed after lockscreen was unlocked.


Status:	RESOLVED FIXED

Product:	gnome-shell
Classification:	Core
Component:	lock-screen
Version:	3.8.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	gnome-shell-maint
QA Contact:	gnome-shell-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2013-04-25 05:16 UTC by sangu
Modified:	2013-05-12 18:20 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
ScreenShield: clear the lock screen early when deactivating (1.43 KB, patch) 2013-05-12 17:46 UTC, Giovanni Campagna	committed	Details \| Review
ScreenShield: mark music notifications as acknowledged immediately (2.22 KB, patch) 2013-05-12 17:46 UTC, Giovanni Campagna	none	Details \| Review
ScreenShield: mark music notifications as acknowledged immediately (2.22 KB, patch) 2013-05-12 18:06 UTC, Giovanni Campagna	committed	Details \| Review
MessageTray: actually respect other components acking notifications (2.26 KB, patch) 2013-05-12 18:06 UTC, Giovanni Campagna	committed	Details \| Review

Description sangu 2013-04-25 05:16:45 UTC

https://bugzilla.redhat.com/show_bug.cgi?id=952285#c7
1. launch gedit and rhythmbox
2. music play in rhythmbox 
3. focus gedit 
4. ctrl + alt + l
5. stop music in lock-screen
6. type password
7. enter key
gnome-shell crashes

How reproducible:
always

Core was generated by `/usr/bin/gnome-shell'.
Program terminated with signal 5, Trace/breakpoint trap.

+ Trace 231847

#0 g_logv
at gmessages.c line 981
#0 g_logv
at gmessages.c line 981
#1 g_log
at gmessages.c line 1010
#2 st_widget_get_theme_node
at st/st-widget.c line 611
#3 st_bin_get_preferred_width
at st/st-bin.c line 127
#4 clutter_actor_get_preferred_width
at ./clutter-actor.c line 9290
#5 _st_actor_get_preferred_width
at st/st-private.c line 61
#6 st_bin_get_preferred_width
#7 clutter_actor_get_preferred_width
at ./clutter-actor.c line 9290
#8 clutter_bin_layout_get_preferred_width
at ./clutter-bin-layout.c line 332
#9 st_widget_get_preferred_width
at st/st-widget.c line 372
#10 clutter_actor_get_preferred_width
at ./clutter-actor.c line 9290
#11 clutter_actor_allocate_align_fill
#12 clutter_bin_layout_allocate
at ./clutter-bin-layout.c line 538
#13 st_widget_allocate
at st/st-widget.c line 412
#14 clutter_actor_allocate_internal
at ./clutter-actor.c line 9677
#15 clutter_actor_set_animatable_property
at ./clutter-actor.c line 14655
#16 _clutter_actor_create_transition
at ./clutter-actor.c line 18779
#17 clutter_actor_allocate
at ./clutter-actor.c line 9804
#18 clutter_actor_allocate_align_fill
#19 clutter_bin_layout_allocate
at ./clutter-bin-layout.c line 538
#20 st_widget_allocate
at st/st-widget.c line 412
#21 clutter_actor_allocate_internal
at ./clutter-actor.c line 9677
#22 clutter_actor_set_animatable_property
at ./clutter-actor.c line 14655
#23 _clutter_actor_create_transition
at ./clutter-actor.c line 18779
#24 clutter_actor_allocate
at ./clutter-actor.c line 9804
#25 clutter_actor_allocate_preferred_size
at ./clutter-actor.c line 15208
#26 ffi_call_unix64
from /lib64/libffi.so.6
#27 ffi_call
from /lib64/libffi.so.6
#28 gjs_invoke_c_function
at gi/function.c line 893
#29 function_call
at gi/function.c line 1202
#30 CallJSNative
at jscntxtinlines.h line 701
#31 js::Invoke
at jsinterp.cpp line 696
#32 js::Interpret
at jsinterp.cpp line 4810
#33 js::RunScript
at jsinterp.cpp line 653
#34 js::Invoke
at jsinterp.cpp line 740
#35 js::ExternalInvoke
#36 JS_CallFunctionValue
at jsapi.cpp line 5145
#37 gjs_call_function_value
at gjs/jsapi-util.c line 715
#38 gjs_closure_invoke
at gi/closure.c line 276
#39 closure_marshal
at gi/value.c line 129
#40 g_closure_invoke
at gclosure.c line 777
#41 signal_emit_unlocked_R
#42 g_signal_emit_valist
at gsignal.c line 3328
#43 g_signal_emit
at gsignal.c line 3384
#44 shell_generic_container_allocate
at shell-generic-container.c line 74
#45 clutter_actor_allocate_internal
at ./clutter-actor.c line 9677
#46 clutter_actor_set_animatable_property
at ./clutter-actor.c line 14655
#47 _clutter_actor_create_transition
at ./clutter-actor.c line 18779
#48 clutter_actor_allocate
#49 clutter_actor_allocate_preferred_size
at ./clutter-actor.c line 15208
#50 clutter_fixed_layout_allocate
at ./clutter-fixed-layout.c line 145
#51 clutter_actor_maybe_layout_children
at ./clutter-actor.c line 2509
#52 clutter_actor_set_allocation
at ./clutter-actor.c line 9919
#53 clutter_stage_allocate
at ./clutter-stage.c line 399
#54 clutter_actor_allocate_internal
at ./clutter-actor.c line 9677
#55 clutter_actor_set_animatable_property
#56 _clutter_actor_create_transition
at ./clutter-actor.c line 18779
#57 clutter_actor_allocate
at ./clutter-actor.c line 9804
#58 _clutter_stage_maybe_relayout
at ./clutter-stage.c line 1100
#59 _clutter_stage_do_update
at ./clutter-stage.c line 1224
#60 master_clock_update_stages
at ./clutter-master-clock.c line 457
#61 clutter_clock_dispatch
at ./clutter-master-clock.c line 589
#62 g_main_dispatch
at gmain.c line 3054
#63 g_main_context_dispatch
at gmain.c line 3630
#64 g_main_context_iterate
#65 g_main_loop_run
at gmain.c line 3895
#66 meta_run
at core/main.c line 556
#67 main
at main.c line 430


https://retrace.fedoraproject.org/faf/reports/98851/

----
gnome-shell-3.8.1-1.fc19.x86_64
clutter-1.14.2-1.fc19.x86_64
mutter-3.8.1-1.fc19.x86_64
gtk3-3.8.1-1.fc19.x86_64
glib2-2.36.1-1.fc19.x86_64
rhythmbox-2.99.1-1.fc19.x86_64
gedit-3.8.1-1.fc19.x86_64

Comment 1 Giovanni Campagna 2013-05-12 17:46:49 UTC

Created attachment 243934 [details] [review]
ScreenShield: clear the lock screen early when deactivating

Upon popMode, MessageTray will try readding all notifications
to their rightful parent, so we must tell NotificationBox to
relinquish them before st_bin_set_child() fails (leaving a dangling
child pointer and crashing at the next allocation)

Comment 2 Giovanni Campagna 2013-05-12 17:46:56 UTC

Created attachment 243935 [details] [review]
ScreenShield: mark music notifications as acknowledged immediately

After all, the user is seeing it (or will see them before unlocking),
so there is no point in queing them as banners.

Comment 3 Giovanni Campagna 2013-05-12 18:06:05 UTC

Created attachment 243938 [details] [review]
ScreenShield: mark music notifications as acknowledged immediately

After all, the user is seeing it (or will see them before unlocking),
so there is no point in queing them as banners.

Comment 4 Giovanni Campagna 2013-05-12 18:06:10 UTC

Created attachment 243939 [details] [review]
MessageTray: actually respect other components acking notifications

If a notification is marked acknowledged from outside, filter it
out from the queue.

Comment 5 Jasper St. Pierre (not reading bugmail) 2013-05-12 18:10:29 UTC

Review of attachment 243934 [details] [review]:

OK.

Comment 6 Jasper St. Pierre (not reading bugmail) 2013-05-12 18:11:45 UTC

Review of attachment 243939 [details] [review]:

OK.

Comment 7 Jasper St. Pierre (not reading bugmail) 2013-05-12 18:12:13 UTC

Review of attachment 243938 [details] [review]:

OK.

Comment 8 Giovanni Campagna 2013-05-12 18:19:44 UTC

Attachment 243934 [details] pushed as 61fe000 - ScreenShield: clear the lock screen early when deactivating
Attachment 243938 [details] pushed as 2591bc9 - ScreenShield: mark music notifications as acknowledged immediately
Attachment 243939 [details] pushed as ae6d7bb - MessageTray: actually respect other components acking notifications

Attachment 243934 [details] pushed to gnome-3-8 as well.