After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698798 - GsmAutostartApp: Don't return NULL from constructor, use GInitable
GsmAutostartApp: Don't return NULL from constructor, use GInitable
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-24 21:21 UTC by Colin Walters
Modified: 2013-04-24 23:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-GsmAutostartApp-Don-t-return-NULL-from-constructor-u.patch (7.82 KB, patch)
2013-04-24 21:21 UTC, Colin Walters 		accepted-commit_now Details | Review

Description Colin Walters 2013-04-24 21:21:00 UTC 
Recent GObject changes break this; it was never a supported operation.
GInitable is the way to return errors to callers.
---
 gnome-session/gsm-autostart-app.c |   73 ++++++++++++++++++-------------------
 gnome-session/gsm-autostart-app.h |    3 +-
 gnome-session/gsm-manager.c       |    6 ++-
 3 files changed, 42 insertions(+), 40 deletions(-)
Comment 1 Colin Walters 2013-04-24 21:21:25 UTC 
Created attachment 242370 [details] [review]
0001-GsmAutostartApp-Don-t-return-NULL-from-constructor-u.patch
Comment 2 Matthias Clasen 2013-04-24 22:36:38 UTC 
Review of attachment 242370 [details] [review]:

Looks good