After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698761 - remoteSearch: support serialized GIcons
remoteSearch: support serialized GIcons
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-24 16:09 UTC by Cosimo Cecchi
Modified: 2013-04-24 19:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remoteSearch: support serialized GIcons (4.28 KB, patch)
2013-04-24 16:09 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-04-24 16:09:00 UTC 
See attached patch
Comment 1 Cosimo Cecchi 2013-04-24 16:09:02 UTC 
Created attachment 242340 [details] [review]
remoteSearch: support serialized GIcons

Since [1], GIO supports generic serialization and deserialization of a
GIcon into a GVariant. This is also implemented by GdkPixbuf and could be
used instead of our homegrown code for it.

This commit adds support to another 'icon' key in the metas dictionary
returned by applications for it. The previous 'gicon' and 'icon-data'
keys are still parsed and supported as before, but are now deprecated.

[1]
https://git.gnome.org/browse/glib/commit/?id=c16f914b40c749b938490a4e10a3c54ec1855c42
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-04-24 16:37:41 UTC 
Review of attachment 242340 [details] [review]:

OK.
Comment 3 Cosimo Cecchi 2013-04-24 19:55:20 UTC 
Attachment 242340 [details] pushed as 17df668 - remoteSearch: support serialized GIcons