After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698671 - Refactor event handling code in ClutterGestureAction
Refactor event handling code in ClutterGestureAction
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterAction
1.14.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-23 15:51 UTC by Lionel Landwerlin
Modified: 2013-04-23 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Event refactoring (7.26 KB, patch)
2013-04-23 15:55 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2013-04-23 15:51:34 UTC 
Little refactoring to make things easier to read.
Comment 1 Lionel Landwerlin 2013-04-23 15:55:32 UTC 
Created attachment 242252 [details] [review]
Event refactoring
Comment 2 Emmanuele Bassi (:ebassi) 2013-04-23 16:10:24 UTC 
Review of attachment 242252 [details] [review]:

looks generally okay to me.

::: clutter/clutter-gesture-action.c
@@ +225,3 @@
 
+static void
+gesture_update_motion_point (GesturePoint *point, ClutterEvent *event)

code style: newline between arguments.

@@ +246,3 @@
+
+static void
+gesture_update_release_point (GesturePoint *point, ClutterEvent *event)

coding style: newline between arguments
Comment 3 Lionel Landwerlin 2013-04-23 16:42:16 UTC 
Pushed.