After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698663 - Remove user with auto login enable, after reboot gdm is blocked
Remove user with auto login enable, after reboot gdm is blocked
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-23 15:13 UTC by Jean-Benoit MARTIN
Modified: 2013-06-04 10:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to remove autologin (1.06 KB, patch)
2013-04-24 12:15 UTC, Jean-Benoit MARTIN
committed Details | Review

Description Jean-Benoit MARTIN 2013-04-23 15:13:09 UTC
2 users with account enable ( user1 and user2 )

log into user1
enable autologin for user2
delete user2 
reboot

the autologin of user2 is still active in /etc/gdm/custom.conf
# GDM configuration storage

[daemon]

AutomaticLoginEnable=True
AutomaticLogin=user2

[security]

[xdmcp]

[greeter]

[chooser]

[debug]

after reboot gdm is blocked
Comment 1 Jean-Benoit MARTIN 2013-04-24 12:15:21 UTC
Created attachment 242317 [details] [review]
patch to remove autologin

Fix to remove autologin when user is deleted
Comment 2 Simon McVittie 2013-04-25 14:50:50 UTC
Vaguely related to Bug #698647, but this one is more obviously a bug, whereas 698647 is more debatable.
Comment 3 Simon McVittie 2013-04-25 14:56:58 UTC
Review of attachment 242317 [details] [review]:

(I am not an accountsservice or gnome-control-center developer.)

Shouldn't the accountsservice daemon automatically turn off gdm automatic login before it deletes a user anyway? I can't think of any situation in which you could want gdm to remain configured to auto-log-in as a particular user, after that user has already been deleted.

(Compare Bug #689647, where I think it should be gnome-control-center that applies policy - I can see a rather tenuous use-case for having an account that logs in automatically on boot, but cannot successfully answer any password queries, so accountsservice might reasonably want to avoid imposing policy.)

::: panels/user-accounts/um-user-panel.c
@@ +410,3 @@
 
+        /* remove autologin */
+        if ( act_user_get_automatic_login (user)) {

Whitespace: shouldn't have a space before "act".
Comment 4 Jean-Benoit MARTIN 2013-04-26 07:21:46 UTC
the bug is duplicated https://bugzilla.gnome.org/show_bug.cgi?id=683337

a bug on accountsservices is already open
https://bugs.freedesktop.org/show_bug.cgi?id=54506