After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698572 - Logic handling enabled/disabled is flawed
Logic handling enabled/disabled is flawed
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: rygel-preferences
git master
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-22 14:11 UTC by Jens Georg
Modified: 2013-04-30 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Check that autostart file exists (2.34 KB, patch)
2013-04-30 08:39 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2013-04-22 14:11:02 UTC 
The logic that handles the checkbox is completely weird. Partially it depends on the existence the user's configuration file, partially it doesn't and it doesn't take the existence of the symlink into account, causing bugs like 

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703281

and generally confusing people. I think even with the g-c-c applet in place this is worth fixing since there are other entities that might want to use rygel-preferences.
Comment 1 Jens Georg 2013-04-30 08:39:23 UTC 
Created attachment 242890 [details] [review]
ui: Check that autostart file exists

Preferences should only claim that sharing is enabled when the autostart file
exists in addition to the enable_upnp setting.

Fixes confusion in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703281
Comment 2 Jens Georg 2013-04-30 08:39:38 UTC 
Attachment 242890 [details] pushed as 47ca65d - ui: Check that autostart file exists