GNOME Bugzilla – Bug 698456
jhbuild fails to create checkoutroot directory
Last modified: 2021-05-17 15:57:02 UTC
In the jhbuildrc file, even when the 'checkoutroot' directory's path is specified as one of the user's owned folders (a writable directory), it fails to create them. While, in case of the path of 'prefix' directory, it succeeds if the path is to a user owned directory, i.e. a writable directory. Solution: Have to manually create the 'checkoutroot' directory, in a directory, where the user is permitted to write. OS: Ubuntu 12.04 Desktop Environment: Gnome 3.4.2.1
Created attachment 242373 [details] [review] My proposed patch It makes sure that the checkoutroot directory is created if the location provided is writable. (does the same for prefix root directory too)
Quick review: - Your indentation is wrong (PEP 8 dictates 4 spaces); - You should try to catch specific exceptions; - This shouldn't happen in sanitycheck but in config.py, setup_env. (there is already a bunch of makedirs calls there).
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/jhbuild/-/issues/168.