GNOME Bugzilla – Bug 698439
Merge "Completed On" filter option with "Follow Up"
Last modified: 2015-03-23 11:12:13 UTC
"Edit > Message Filters > Add > Add Condition" offers "Completed On". As parameter I expected a date selector, but it offers only "is set" and "is not set". I *assume* it refers to the "Follow Up" item right before, but the "Message > Mark Up > Follow Up..." dialog only offers a "Completed" checkbox. If the filter criterion refers to this flag, then it should maybe get renamed from "Completed On" to "Follow Up Completed", or even better somehow merged into "Follow Up" which currently only offers "is Flagged" and "is not Flagged" (yes, with that capitalization). If not merging it, maybe rename "Follow Up" to "Follow Up Flag" to better differentiate? After clarifying help/C/mail-filters-conditions.page needs an update.
I moved the message in the docs to xinclude-filter-vfolder-conditions.xml
I think I'd actually merge both into the "Status" condition. So you'd have: [Status] [is ] [Replied to ] [is not] [Draft ] [Imporant ] [Read ] [Junk ] [Flagged for Followup] (new) [Followup Completed ] (new) I think that would cover all the variations, right? Need to research this a bit more to make sure I'm not missing the rationale for the "Follow Up" / "Completed On" conditions being split out.
Of course, migrating existing filters could be fairly painful if we decide to rearrange conditions like this.
The "Completed On" is a date, when the follow-up flag was completed, but the filter is there to search for completed and uncompleted follow-ups only. I would not merge the two under the Status, I'm afraid people might not find it there. Let's rename the two followup options instead.
Created attachment 299302 [details] [review] evo patch for evolution; This merges "Completed On" with "Follow Up" criterion making it options: is Flagged is not Flagged is Completed is not Completed (really this capitalization). Feel free to complain before I'll commit for 3.17.1.
Created commit 9774499 in evo master (3.17.1+)