After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698382 - GSignal: fix annotation on the instance parameter
GSignal: fix annotation on the instance parameter
Status: RESOLVED DUPLICATE of bug 685387
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-19 16:50 UTC by Giovanni Campagna
Modified: 2015-02-07 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GSignal: fix annotation on the instance parameter (5.82 KB, patch)
2013-04-19 16:50 UTC, Giovanni Campagna
none Details | Review

Description Giovanni Campagna 2013-04-19 16:50:39 UTC
If this is approved, I'll also do a round of annotation updates in
gobject-introspection.
Comment 1 Giovanni Campagna 2013-04-19 16:50:42 UTC
Created attachment 241930 [details] [review]
GSignal: fix annotation on the instance parameter

The instance parameter to the various g_signal functions is a gpointer
because technically it is valid to install signals on any GTypeInstance.
Practically speaking, in all language bindings, only GObjects have
signals anyway, so it makes sense to export them as objects.
Comment 2 Simon Feltman 2013-05-01 03:01:26 UTC
Just FYI, there was another version of this ticket with a similar patch that I closed out because it didn't get much traction (bug 633999). For PyGObject we hacked around it and changing these annotations would break PyGObject at this point. I would be happy to get rid of the hackery though, so if this ever goes in, please communicate with the PyGObject maintainers or better yet submit a patch removing the usage of "__gpointer__" in:
https://git.gnome.org/browse/pygobject/tree/gi/overrides/GObject.py
Comment 3 Martin Pitt 2013-09-02 06:29:23 UTC

*** This bug has been marked as a duplicate of bug 685387 ***
Comment 4 André Klapper 2015-02-07 16:44:14 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]