After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698231 - One should not be able to minimize g-i-s window
One should not be able to minimize g-i-s window
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
0.8
Other Linux
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-17 19:35 UTC by Baptiste Mille-Mathias
Modified: 2013-04-22 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
driver: Don't allow the main window to be minimized (1.61 KB, patch)
2013-04-18 16:56 UTC, Michael Wood 		needs-work Details | Review

Description Baptiste Mille-Mathias 2013-04-17 19:35:48 UTC 
in the context of the setup where there is no dock, if someone right-click on title-bar and choose "Minimize", there is no easy way to get the window back (just alt-tab, which is not the easiest to find)
Comment 1 Baptiste Mille-Mathias 2013-04-17 19:36:13 UTC 
Version tested: gnome-initial-setup-0.8-3.fc19.x86_64
Comment 2 Matthias Clasen 2013-04-17 22:06:55 UTC 
Not particular to gnome-initial-setup. This applies to your firefox window just as well.
Comment 3 Baptiste Mille-Mathias 2013-04-18 07:38:50 UTC 
Ok, I didn't noticed there was a firefox window during the process.
Comment 4 Michael Wood 2013-04-18 11:34:34 UTC 
You can apparently minimise the window in initial-setup mode as the window manager is running, perhaps in this mode we should gtk_window_set_decorated (window, FALSE)
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-04-18 13:26:05 UTC 
(In reply to comment #2)
> Not particular to gnome-initial-setup. This applies to your firefox window just
> as well.

Well, there's no overview in initial-setup mode. Let's just disable minimization.
Comment 6 Michael Wood 2013-04-18 16:56:17 UTC 
Created attachment 241838 [details] [review]
driver: Don't allow the main window to be minimized
Comment 7 Matthias Clasen 2013-04-18 23:44:15 UTC 
Review of attachment 241838 [details] [review]:

ok
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-04-19 14:12:40 UTC 
Review of attachment 241838 [details] [review]:

::: gnome-initial-setup/gis-driver.c
@@ +239,3 @@
+  window = gtk_widget_get_window (GTK_WIDGET (priv->main_window));
+  /* disable minimize */
+  gdk_window_set_functions (window, GDK_FUNC_ALL | GDK_FUNC_MINIMIZE);

Uh, doesn't this need to be GDK_FUNC_ALL & ~GDK_FUNC_MINIMIZE ?
Comment 9 Michael Wood 2013-04-19 15:17:43 UTC 
https://developer.gnome.org/gdk/2.22/gdk-Windows.html#gdk-window-set-functions says "The functions argument is the logical OR of values from the GdkWMFunction enumeration. If the bitmask includes GDK_FUNC_ALL, then the other bits indicate which functions to disable; if it doesn't include GDK_FUNC_ALL, it indicates which functions to enable."

So it probably should be a logical OR not bitwise infact
Comment 10 Matthias Clasen 2013-04-19 20:06:27 UTC 
no, bitwise was quite ok
Comment 11 Michael Wood 2013-04-22 12:43:04 UTC 
Is this back to accept commit now then?
Comment 12 Jasper St. Pierre (not reading bugmail) 2013-04-22 15:06:14 UTC 
Yeah, I misunderstood the terrible API.
Comment 13 Michael Wood 2013-04-22 15:33:48 UTC 
Pushed	0d7573a49c0439c6fa53cc736bf588542d53ab3f