GNOME Bugzilla – Bug 698200
No longer displays realmd domain hint
Last modified: 2013-05-03 19:57:33 UTC
The hint once joined to a domain is no longer being emitted in the GDM 'User name' screen. I think that since this commit: 1ec0665b631965b8c73277374dddde8b1d8b6d1e The InfoQuery signal is not being emitted (which causes the the code in util.js listening to 'info-query' not to be run).
So commit 1ec0665b631965b8c73277374dddde8b1d8b6d1e is about porting the fallback greeter to libgdm. We don't use the fallback greeter anymore (and the fallback greeter never showed realmd hints). The InfoQuery signal is emitted whenever a non-secret username is requested by PAM. The canonical info-query is "Username: ". This is probably caused by this commit: https://git.gnome.org/browse/gnome-shell/commit/?id=1ae0fadbf483128e27565baba6e8684bc5defca2 We probably need to move the realmd hit from _onInfoQuery to _askForUsernameAndLogIn:
above where i wrote "non-secret username" I meant to say "non-secret question"
Created attachment 241879 [details] [review] gdm: Fix regression where domain login hint not shown Also only keep around realmd while we're actually using it, allow it to quit if no other clients are active.
Patch tested on gnome-3-8, applies to master.
Stef or Ray, Is this bug fixed ? does it require the backport of the patch on gnome-3-8 ? Regards
I don't think this is committed yet. It needs review. Ideally I'd like it to get on both the gnome-3-8 branch and master.
Review of attachment 241879 [details] [review]: Looks good to me, though I haven't been able to actually test this.
Attachment 241879 [details] pushed as 47dee22 - gdm: Fix regression where domain login hint not shown Thanks for the review. Pushed to gnome-3-8, and will push to master shortly.