After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698189 - [PATCH] Port the noise-spread plug-in to gegl ops
[PATCH] Port the noise-spread plug-in to gegl ops
Status: RESOLVED OBSOLETE
Product: GEGL
Classification: Other
Component: operations
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2013-04-17 12:31 UTC by Samuel Pitoiset
Modified: 2013-11-17 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
noise-spread-gegl-ops-patch (5.89 KB, patch)
2013-04-17 12:31 UTC, Samuel Pitoiset 		none Details | Review
noise-spread with GIMP (204.98 KB, image/png)
2013-04-17 12:32 UTC, Samuel Pitoiset 		  Details
noise-spread with GEGL (169.17 KB, image/jpeg)
2013-04-17 12:32 UTC, Samuel Pitoiset 		  Details
noise-spread-gegl-ops-patch (6.99 KB, patch)
2013-04-18 12:06 UTC, Samuel Pitoiset 		none Details | Review
noise-spread-gegl-ops-patch-final (7.10 KB, patch)
2013-04-18 18:51 UTC, Samuel Pitoiset 		none Details | Review

Description Samuel Pitoiset 2013-04-17 12:31:50 UTC 
Created attachment 241733 [details] [review]
noise-spread-gegl-ops-patch

Hi,

I ported the noise-spread plug-in from GIMP (ie. plug-ins/common/noise-spread.c) to GEGL ops. The algorithm works fine, however I have some glitchs (ie. black pixels) which doesn't appear when I try with GIMP. Let submit a screenshot.
Comment 1 Samuel Pitoiset 2013-04-17 12:32:23 UTC 
Created attachment 241734 [details]
noise-spread with GIMP
Comment 2 Samuel Pitoiset 2013-04-17 12:32:41 UTC 
Created attachment 241735 [details]
noise-spread with GEGL
Comment 3 Samuel Pitoiset 2013-04-18 12:06:43 UTC 
Created attachment 241820 [details] [review]
noise-spread-gegl-ops-patch

Hi,

I fixed the bug previously mentionned, however now the output image is a little shifted. I'll investigate about that issue.
Comment 4 Samuel Pitoiset 2013-04-18 18:51:59 UTC 
Created attachment 241844 [details] [review]
noise-spread-gegl-ops-patch-final

I fixed the bug mentionned above. Actually, the new random positions was not re-centered compared to the source image. Now, the patch works fine! :)
Comment 5 Øyvind Kolås (pippin) 2013-04-18 23:02:38 UTC 
Using gegl_random_* instead of g_random_* would make it possible to get reproducable results from this operation. Most ops relying on random values in GEGL should be using the gegl_random_ family of functions.
Comment 6 Téo Mazars 2013-11-17 11:48:22 UTC 
The operation is already ported to GEGL.

Samuel, thanks for your work anyway! I encourage you to have a look at http://wiki.gimp.org/index.php/Hacking:Porting_filters_to_GEGL to see operations already ported, in case you plan to do further work on the subject. Even though it may not be 100% up to date, so please double check in the source tree, and also feel free to get in touch with us on IRC (irc.gimp.net #gegl)