After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698156 - souphttpsrc: proper SCHEDULING query support
souphttpsrc: proper SCHEDULING query support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-16 18:38 UTC by Philippe Normand
Modified: 2013-04-16 18:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
souphttpsrc: proper SCHEDULING query support (1.63 KB, patch)
2013-04-16 18:45 UTC, Philippe Normand 		committed Details | Review

Description Philippe Normand 2013-04-16 18:38:53 UTC 
Commit b857cb38ddb63af8ba745c10bece8f1b528af4fe was incorrect because hijacking GstPushSrc query response for SCHEDULING. The souphttpsrc element should instead call the parent element query handler first and then add the _BANDWIDTH_LIMITED flag.
Comment 1 Philippe Normand 2013-04-16 18:45:27 UTC 
Created attachment 241675 [details] [review]
souphttpsrc: proper SCHEDULING query support

Chain the query up to parent before adding _BANDWIDTH_LIMITED flag.

Fixes #698156
Comment 2 Tim-Philipp Müller 2013-04-16 18:56:56 UTC 
Thanks, pushed:


commit d975a70f12d13ea057de1ef760a79108ead43990
Author: Philippe Normand <philn@igalia.com>
Date:   Tue Apr 16 20:41:10 2013 +0200

    souphttpsrc: fix SCHEDULING query support
    
    Chain the query up to parent before adding _BANDWIDTH_LIMITED flag,
    so that all the other flags get set, and push mode gets added as
    supported activation mode.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693484
    https://bugzilla.gnome.org/show_bug.cgi?id=698156