GNOME Bugzilla – Bug 698143
API to check if location is currently under the view
Last modified: 2013-04-16 21:43:28 UTC
See patches
Created attachment 241659 [details] [review] Add champlain_view_get_bounding_box() Add method to get bounding box of the view.
Created attachment 241660 [details] [review] Add champlain_bounding_box_covers() Add a method to check if a particular location is covered by a bounding box.
Review of attachment 241659 [details] [review]: Committed.
Review of attachment 241660 [details] [review]: Committed.
Looks useful, thanks. In the future we could actually remove champlain_view_get_center_latitude() and champlain_view_get_center_latitude() from the API since they can be obtained from the bounding box. I've just updated the Since from 0.12 to 0.12.4.
(In reply to comment #5) > Looks useful, thanks. In the future we could actually remove > champlain_view_get_center_latitude() and champlain_view_get_center_latitude() > from the API since they can be obtained from the bounding box. That won't be very convenient so I'd say these api should be kept. One thing i noticed though is that getter names are not following the usual convention of matching respective proprerty names. Either we should deprecate these in favor of champlain_view_get_latitude/longitude() or do the vice versa on the props. > I've just updated the Since from 0.12 to 0.12.4. Thanks!