After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698109 - Disable output port before transition to idle state
Disable output port before transition to idle state
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
1.0.0
Other Linux
: Normal normal
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-16 05:33 UTC by jvarshney20
Modified: 2014-07-23 08:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Error log with --gst-debug=3 (3.23 KB, text/plain)
2013-04-16 05:33 UTC, jvarshney20
  Details
proposed patch (1.32 KB, patch)
2013-04-16 05:52 UTC, jvarshney20
none Details | Review
proposed patch (4.37 KB, patch)
2013-04-16 09:54 UTC, jvarshney20
committed Details | Review

Description jvarshney20 2013-04-16 05:33:29 UTC
Created attachment 241620 [details]
Error log with --gst-debug=3

Not able to play h264 video with gst-omx h264 element( omxh264dec). It results in negotiation error. 

gst-launch output with gst-debug=3 is attached.
Comment 1 jvarshney20 2013-04-16 05:52:57 UTC
Created attachment 241621 [details] [review]
proposed patch
Comment 2 jvarshney20 2013-04-16 05:56:51 UTC
On further debugging, it was found that component is being transitioned to idle state and to complete that transition buffers for all enabled ports should be allocated/provided. But buffers are only being allocated for input port so component is not able to complete the transition.

In between request to disable output port is being sent which is resulting in timeout.


proposed patch is attached.
Comment 3 Sebastian Dröge (slomo) 2013-04-16 09:00:47 UTC
On which hardware with which OpenMAX IL implementation are you testing this? The patch looks fine though, similar changes are probably needed in the audio/video encoders too.
Comment 4 Sebastian Dröge (slomo) 2013-04-16 09:01:50 UTC
Could you attach a patch in git format-patch style? And if you want, also the same changes for the encoders, otherwise I'll add them myself there.
Comment 5 jvarshney20 2013-04-16 09:54:55 UTC
Created attachment 241625 [details] [review]
proposed patch
Comment 6 jvarshney20 2013-04-16 09:57:01 UTC
I am testing this on Nvidia implementation of OpenMax IL.
Comment 7 Sebastian Dröge (slomo) 2013-04-16 10:48:07 UTC
Thanks, pushed:

commit 960590f92ff6535565226dfab6fd52082dd6ee2c
Author: jitendra <jvarshney20@gmail.com>
Date:   Tue Apr 16 14:50:49 2013 +0530

    omx: Disable output port before transition to idle state
    
    https://bugzilla.gnome.org/show_bug.cgi?id=698109

If you're interested we could also provide a configuration file for the NVIDIA OpenMAX IL, together with a --with-omx-target=nvidia switch for configure.
Comment 8 Erwin Rol 2014-02-24 12:38:33 UTC
Hello "jvarshney20" ,

I am trying to get gst-omx working on a seco t30 with a Tegra 3 CPU. I am very interested in your "configuration file for the NVIDIA
OpenMAX IL, together with a --with-omx-target=nvidia switch for configure" :-)

Could you post it on the gst-openmax mailing list?

- Erwin