GNOME Bugzilla – Bug 698090
scanner assumes clang is cl, the Microsoft compiler
Last modified: 2015-02-07 16:58:13 UTC
In giscanner/dumper.py the init function of the DumpCompiler class has a check for "cl" in the compiler command. If that matches, it does assume you're using a Microsoft compiler. Unfortunately, clang also has cl as substring. Therefore Microsoft compiler arguments are passed to clang, which makes compiles fail. See the following snippet, line 92: > if 'cl' in self._compiler_cmd: > self._pkgconfig_msvc_flags = '--msvc-syntax' The if could be replaced with the following line: > if not 'clang' in self._compiler_cmd and 'cl' in self._compiler_cmd: I don't know if there's a cleaner way to fix it.
Created attachment 243017 [details] [review] Do not misdetect clang as the Microsoft C compiler Just because they both start with 'cl'.
thanks Patrick. I ended up writing a slightly different patch.
Review of attachment 243017 [details] [review]: Sure.
Attachment 243017 [details] pushed as 863ceb7 - Do not misdetect clang as the Microsoft C compiler
*** Bug 721996 has been marked as a duplicate of this bug. ***
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]