After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697917 - classic mode: slider knobs in menus barely visible
classic mode: slider knobs in menus barely visible
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
classic
: 702770 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-04-12 21:18 UTC by Matthias Clasen
Modified: 2013-06-20 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (14.86 KB, image/png)
2013-04-12 21:18 UTC, Matthias Clasen
  Details
classic: Adjust popup menu slider style (899 bytes, patch)
2013-05-13 20:49 UTC, Florian Müllner
none Details | Review
Knob-shot (2.85 KB, image/png)
2013-05-14 12:25 UTC, Florian Müllner
  Details
classic: Adjust popup menu slider style (899 bytes, patch)
2013-05-14 19:17 UTC, Jakub Steiner
none Details | Review
popupMenu: Allow for an optional border for slider handle (1.79 KB, patch)
2013-05-21 17:43 UTC, Florian Müllner
committed Details | Review
classic: Adjust popup menu slider style (961 bytes, patch)
2013-05-22 16:24 UTC, Jakub Steiner
none Details | Review
classic: Adjust popup menu slider style (852 bytes, patch)
2013-05-22 16:25 UTC, Jakub Steiner
committed Details | Review

Description Matthias Clasen 2013-04-12 21:18:41 UTC
Created attachment 241405 [details]
screenshot

The light knobs make sense in dark menus, but in classic mode, they are almost invisible.
Comment 1 Florian Müllner 2013-05-13 20:49:15 UTC
Created attachment 244103 [details] [review]
classic: Adjust popup menu slider style

Tentative patch, still missing jimmac-seal-of-approval
Comment 2 Matthias Clasen 2013-05-14 11:11:48 UTC
have a screenshot ?
Comment 3 Florian Müllner 2013-05-14 12:25:06 UTC
Created attachment 244165 [details]
Knob-shot

Sure!
Comment 4 Jakub Steiner 2013-05-14 19:17:07 UTC
I'd rather seejust  the stroke of the slider redefined. I see that while color does affect the slider for .popup-slider-menu-item, redefining border works on the whole rectangular container rather than the round slider itself :/

Just going with a slightly darker fill does make it look less odd though.
Comment 5 Jakub Steiner 2013-05-14 19:17:40 UTC
Created attachment 244234 [details] [review]
classic: Adjust popup menu slider style

The bright white knob doesn't work well with the light popup menu
color, so make it darker in classic mode.
Comment 6 Florian Müllner 2013-05-14 19:37:51 UTC
(In reply to comment #4)
> I'd rather seejust  the stroke of the slider redefined. I see that while color
> does affect the slider for .popup-slider-menu-item, redefining border works on
> the whole rectangular container rather than the round slider itself :/

Looking for -slider-border-color/-slider-border-width?
Comment 7 Jakub Steiner 2013-05-14 19:47:03 UTC
This didn't seem to do nything for me:

  .popup-slider-menu-item {
    color: #ddd;
    -slider-border-color: red;
    -slider-border-width: 1px;
  }
Comment 8 Florian Müllner 2013-05-14 19:50:38 UTC
Probably missing !important, but yeah, it's not what you are looking for - looks like it controls the trough's border color where it's inactive, not the knob.
To get this, we'd need to add another pair of custom properties.
Comment 9 Florian Müllner 2013-05-21 17:43:52 UTC
Created attachment 244974 [details] [review]
popupMenu: Allow for an optional border for slider handle

While the default style works well will a solid handle, using both
border and fill color would be desirable in classic mode. Add the
necessary (optional) style properties to allow this.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-05-21 18:04:19 UTC
Review of attachment 244974 [details] [review]:

Looks good.
Comment 11 Jakub Steiner 2013-05-22 16:24:36 UTC
Created attachment 245061 [details] [review]
classic: Adjust popup menu slider style

The bright white knob doesn't work well with the light popup menu
color, so make it darker in classic mode.
Comment 12 Jakub Steiner 2013-05-22 16:25:37 UTC
Created attachment 245062 [details] [review]
classic: Adjust popup menu slider style
Comment 13 Florian Müllner 2013-05-22 16:47:22 UTC
Comment on attachment 244974 [details] [review]
popupMenu: Allow for an optional border for slider handle

Attachment 244974 [details] pushed as bbb23b5 - popupMenu: Allow for an optional border for slider handle

It does what jimmac wants it to do, so pushing ...
Comment 14 Florian Müllner 2013-05-22 16:48:27 UTC
Review of attachment 245062 [details] [review]:

LGTM
Comment 15 Florian Müllner 2013-06-07 18:18:36 UTC
Attachment 245062 [details] pushed as 505220f - classic: Adjust popup menu slider style
Comment 16 Jakub Steiner 2013-06-20 18:37:36 UTC
*** Bug 702770 has been marked as a duplicate of this bug. ***