GNOME Bugzilla – Bug 697917
classic mode: slider knobs in menus barely visible
Last modified: 2013-06-20 18:37:36 UTC
Created attachment 241405 [details] screenshot The light knobs make sense in dark menus, but in classic mode, they are almost invisible.
Created attachment 244103 [details] [review] classic: Adjust popup menu slider style Tentative patch, still missing jimmac-seal-of-approval
have a screenshot ?
Created attachment 244165 [details] Knob-shot Sure!
I'd rather seejust the stroke of the slider redefined. I see that while color does affect the slider for .popup-slider-menu-item, redefining border works on the whole rectangular container rather than the round slider itself :/ Just going with a slightly darker fill does make it look less odd though.
Created attachment 244234 [details] [review] classic: Adjust popup menu slider style The bright white knob doesn't work well with the light popup menu color, so make it darker in classic mode.
(In reply to comment #4) > I'd rather seejust the stroke of the slider redefined. I see that while color > does affect the slider for .popup-slider-menu-item, redefining border works on > the whole rectangular container rather than the round slider itself :/ Looking for -slider-border-color/-slider-border-width?
This didn't seem to do nything for me: .popup-slider-menu-item { color: #ddd; -slider-border-color: red; -slider-border-width: 1px; }
Probably missing !important, but yeah, it's not what you are looking for - looks like it controls the trough's border color where it's inactive, not the knob. To get this, we'd need to add another pair of custom properties.
Created attachment 244974 [details] [review] popupMenu: Allow for an optional border for slider handle While the default style works well will a solid handle, using both border and fill color would be desirable in classic mode. Add the necessary (optional) style properties to allow this.
Review of attachment 244974 [details] [review]: Looks good.
Created attachment 245061 [details] [review] classic: Adjust popup menu slider style The bright white knob doesn't work well with the light popup menu color, so make it darker in classic mode.
Created attachment 245062 [details] [review] classic: Adjust popup menu slider style
Comment on attachment 244974 [details] [review] popupMenu: Allow for an optional border for slider handle Attachment 244974 [details] pushed as bbb23b5 - popupMenu: Allow for an optional border for slider handle It does what jimmac wants it to do, so pushing ...
Review of attachment 245062 [details] [review]: LGTM
Attachment 245062 [details] pushed as 505220f - classic: Adjust popup menu slider style
*** Bug 702770 has been marked as a duplicate of this bug. ***