After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697876 - [PATCH] Port the edge neon plug-in to GEGL ops (work in progress)
[PATCH] Port the edge neon plug-in to GEGL ops (work in progress)
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: operations
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2013-04-12 13:43 UTC by Samuel Pitoiset
Modified: 2017-04-29 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Skeleton of the edge neon GEGL operation (5.16 KB, patch)
2013-04-12 13:45 UTC, Samuel Pitoiset
none Details | Review
Proposed GEGL port of edge-neon (18.88 KB, patch)
2017-01-22 02:06 UTC, Peter O'Regan
none Details | Review

Description Samuel Pitoiset 2013-04-12 13:43:25 UTC
Hi,

I'm trying to port the edge neon plug-in to GEGL operations as a qualification task for the GSoC 2013. At the moment, this patch does nothing, it's just a skeleton but I'll improve it as soon as possible. For doing that, I still have to understand a bit more the GEGL API and to study the algorithm.
Comment 1 Samuel Pitoiset 2013-04-12 13:45:04 UTC
Created attachment 241348 [details] [review]
Skeleton of the edge neon GEGL operation
Comment 2 Peter O'Regan 2017-01-22 02:05:36 UTC
I've attached a proposed version of the edge-neon ported to GEGL. It's not yet optimized for speed, but it replicates the old Filter->Edge Detection-> Neon algorithm within the GEGL framework.
Comment 3 Peter O'Regan 2017-01-22 02:06:22 UTC
Created attachment 343966 [details] [review]
Proposed GEGL port of edge-neon
Comment 4 Øyvind Kolås (pippin) 2017-01-22 03:46:15 UTC
Pushed to master with some additional cleanups, due to computing the full IIR always, this is slower than the plug-in, but the Peter O'Regan plans to look into speeding it up by making use of the seperability.

commit f63f36daf4ee37cdb44e149f851a8ad6900aba86
Author: Øyvind Kolås <pippin@gimp.org>

Date:   Sun Jan 22 04:06:31 2017 +0100

    edge-neon: use single precision float buffers

commit 07b4c549a34280ad99341a20f99f1ccc543d835b
Author: Øyvind Kolås <pippin@gimp.org>
Date:   Sun Jan 22 04:00:17 2017 +0100

    po: add edge-neon.c

commit e2ac50c34ec5a44d3aafa3586682f78eddfd78b9
Author: Øyvind Kolås <pippin@gimp.org>
Date:   Sun Jan 22 03:59:18 2017 +0100

    edge-neon: use R'G'B'A formats in all places RGBA was used

commit 2844f005f2205c5817d279f02ba58049216b0c10
Author: Peter O'Regan <peteroregan@gmail.com>
Date:   Sat Jan 21 20:40:08 2017 -0500

    Add edge-neon GEGL Port
    
        Ports edge-neon to GEGL. Current implementation is not the most
        efficient, but it matches the output from the GIMP Filter menu, provided
        that the Gamma-Hack is enabled. Optimizations to follow.
    
        Current methodology is slow and will need to be adjusted. Excess calls are
        made and the Gaussian separability is not yet enabled.
    
        https://bugzilla.gnome.org/show_bug.cgi?id=697876