After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697843 - Use command line info from libosinfo
Use command line info from libosinfo
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-12 01:13 UTC by Fabiano Fidêncio
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
installer: Use command line info from libosinfo (1.63 KB, patch)
2013-04-12 01:13 UTC, Fabiano Fidêncio 		committed Details | Review
configure: Require libosinfo >= 0.2.7 (720 bytes, patch)
2013-04-18 01:23 UTC, Fabiano Fidêncio 		committed Details | Review

Description Fabiano Fidêncio 2013-04-12 01:13:15 UTC 
Needs to wait for the approval of these 2 patches:
https://www.redhat.com/archives/libosinfo/2013-April/msg00090.html
https://www.redhat.com/archives/libosinfo/2013-April/msg00091.html
Comment 1 Fabiano Fidêncio 2013-04-12 01:13:18 UTC 
Created attachment 241315 [details] [review]
installer: Use command line info from libosinfo

As libosinfo is able to provide the command line necessary to load install
script files, let's use this info instead of hardcode it in our code.
Comment 2 Christophe Fergeau 2013-04-12 08:35:33 UTC 
Review of attachment 241315 [details] [review]:

::: src/unattended-installer.vala
@@ +293,3 @@
     }
 
+    public override void set_direct_boot_params (GVirConfig.DomainOs domain_os) {

I don't think this is worth renaming

@@ +299,1 @@
         var script = scripts.get_nth (0) as InstallScript;

At some point, it would be nice if we could remove the hardcoded get_nth(0) here :)
Comment 3 Christophe Fergeau 2013-04-12 10:46:48 UTC 
Review of attachment 241315 [details] [review]:

::: src/unattended-installer.vala
@@ +301,3 @@
+        domain_os.set_kernel (kernel_file.get_path ());
+        domain_os.set_ramdisk (initrd_file.get_path ());
+        domain_os.set_cmdline (script.generate_command_line (os, config));

I was pointed out on IRC that the renaming of os to domain_os made that line more readable, so disregard my previous comment.
Comment 4 Fabiano Fidêncio 2013-04-18 01:23:39 UTC 
Created attachment 241788 [details] [review]
configure: Require libosinfo >= 0.2.7
Comment 5 Zeeshan Ali 2013-04-18 01:27:54 UTC 
Review of attachment 241788 [details] [review]:

ACK