GNOME Bugzilla – Bug 697797
videosignal ported to 1.0
Last modified: 2018-11-03 13:15:20 UTC
Created attachment 241255 [details] [review] patch to port videosignal to gstreamer 1.0 The elements videoanalyse, videodetect and videomark are not yet ported to gstreamer 1.0. As we needed these in some applications, we ported them ourselves. We did not change names (as requested in a recent FIXME comment) nor functionality and only tested on Linux Ubuntu 12.04 for a limit number of properties. The resulting patch is attached. (for gst-plugin-bad as on 2013-04-11 00:00).
Great, many thanks! One minor niggle: you shouldn't really have to deal with the GstMemory in the GstBuffer, instead just poke at the data[] array in the GstVideoFrame structures directly, it should already be mapped and filled in. http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstvideo.html#GstVideoFrame
how about naming themvideopatterndetect, videopatternmark? maybe the videoanalyse could become videolevel, like the audio one..
Created attachment 241404 [details] [review] updated patch I did an independent port of videoanalyse recently, so I pushed that, and then fixed up your patch to apply on top of it. I've been porting code to 1.0 by regenerating new source code using gst-element-maker in gst-plugins-bad/tools/, and then copying over relevant code from the 0.10 source, and modifying as necessary. I think this will be a more reliable way to get bug-free porting. Note that this doesn't fix any of the problems noticed by Tim.
The best I've come up with so far is simplevideomark and simplevideomarkdetect. Rationale: If SMPTE had a standard method for doing this, we'd probably call it smptevideomark or smpte2999mark. And this is a "simple" method. Also, "markdetect" instead of "detect", because it's specifically detecting the mark.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/92.