GNOME Bugzilla – Bug 697740
move VPN password dialog to libnmgtk
Last modified: 2013-04-11 18:58:54 UTC
Four of the five in-tree VPN plugins have the same password dialog cut-and-paste into them. (It's originally from libgnomeui I think?) Move it to libnmgtk instead.
Created attachment 241190 [details] [review] libnm-gtk: add NMAVpnPasswordDialog Rather than cut+pasting this into each VPN plugin, put it here.
Created attachment 241191 [details] [review] auth-dialog: port to libnm-gtk's NMAVpnPasswordDialog [This is for openswan. The patches for openvpn, pptp, and vpnc are basically identical.]
The only thing I worry about is the increasing dependence on libnm-gtk. I know the reasons for it to exist, but it's technically "private" API that we can change at any time, except the more stuff that uses it, the less flexible we can be with it... In any case, looks good, lets do this for all the VPN plugins.
done