After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697740 - move VPN password dialog to libnmgtk
move VPN password dialog to libnmgtk
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: API
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: 694307
 
 
Reported: 2013-04-10 16:41 UTC by Dan Winship
Modified: 2013-04-11 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libnm-gtk: add NMAVpnPasswordDialog (20.37 KB, patch)
2013-04-10 16:41 UTC, Dan Winship
none Details | Review
auth-dialog: port to libnm-gtk's NMAVpnPasswordDialog (22.94 KB, patch)
2013-04-10 16:42 UTC, Dan Winship
none Details | Review

Description Dan Winship 2013-04-10 16:41:45 UTC
Four of the five in-tree VPN plugins have the same password dialog
cut-and-paste into them. (It's originally from libgnomeui I think?)
Move it to libnmgtk instead.
Comment 1 Dan Winship 2013-04-10 16:41:47 UTC
Created attachment 241190 [details] [review]
libnm-gtk: add NMAVpnPasswordDialog

Rather than cut+pasting this into each VPN plugin, put it here.
Comment 2 Dan Winship 2013-04-10 16:42:41 UTC
Created attachment 241191 [details] [review]
auth-dialog: port to libnm-gtk's NMAVpnPasswordDialog

[This is for openswan. The patches for openvpn, pptp, and vpnc are
basically identical.]
Comment 3 Dan Williams 2013-04-11 18:22:56 UTC
The only thing I worry about is the increasing dependence on libnm-gtk.  I know the reasons for it to exist, but it's technically "private" API that we can change at any time, except the more stuff that uses it, the less flexible we can be with it...

In any case, looks good, lets do this for all the VPN plugins.
Comment 4 Dan Winship 2013-04-11 18:58:54 UTC
done