After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697685 - gnome-tweak-tool unable to find prefs.js for extensions installed at the system level
gnome-tweak-tool unable to find prefs.js for extensions installed at the syst...
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
3.8.1
Depends on:
Blocks:
 
 
Reported: 2013-04-10 05:21 UTC by Ralph Bean
Modified: 2013-04-10 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to find prefs.js for extensions installed in the system. (981 bytes, patch)
2013-04-10 05:21 UTC, Ralph Bean 		none Details | Review

Description Ralph Bean 2013-04-10 05:21:06 UTC 
Created attachment 241113 [details] [review]
Patch to find prefs.js for extensions installed in the system.

gnome-tweak-tool would correctly find the prefs.js file for extensions installed in ~/.local/.  But extensions installed at the system level in /usr/share or /usr/local/share would have their prefs.js files overlooked.

It turns out that extensions include a value for the path to which they are installed which can be used to more consistently find the prefs.js file if it exists.

I've attached a patch which takes advantage of this.

http://threebean.org/patches/gnome-tweak-tool-use-extension-specific-path-to-find-prefs.js.patch
Comment 1 John Stowers 2013-04-10 09:45:01 UTC 
Thanks a lot.
Comment 2 Matthias Clasen 2013-04-10 13:00:50 UTC 
this would be nice to have for 3.8.1 - the classic mode extensions are installed system-wide, and at least the window-list does have preferences.
Comment 3 John Stowers 2013-04-10 14:52:29 UTC 
Hmm, git bz must have errored before it closed this.

Applied to master and the  gnome-3-8 branches.


This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Ralph Bean 2013-04-10 15:18:19 UTC 
Exciting!  Thanks guys.