GNOME Bugzilla – Bug 697644
Support --disable-tests
Last modified: 2018-02-08 12:21:29 UTC
Created attachment 241061 [details] [review] Support --disable-tests I noticed that configure reports "tests: " like gobject-introspection 1.36.0 =============== tests: at the end. I confirmed configure.ac but I don't find --enable-tests nor --disable-tests configuration. I assume that developers wanted to support --enable-tests/--disable-tests but they are busy. So I've implemented it. See the attached patch for details. The default behavior is "--enable-tests". It is the same behavior as the current behavior.
Review of attachment 241061 [details] [review]: Thanks for the patch! You're right the developers are busy =) Wouldn't it be simpler to just do in Makefile.am: if ENABLE_TESTS SUBDIRS += tests endif ?
(In reply to comment #1) > if ENABLE_TESTS > SUBDIRS += tests > endif Wouldn't that break the installation of test sources into "$(datadir)/gobject-introspection-1.0/tests" ? afaik at least pygobject and gjs expect gimarshallingtests.[c|h] and regress.[c|h] to live there unconditionally, gjs also wants warnlib.[c|h]
That sounds really suboptimal. If pygobject and gjs want to use innards of glib tests, the should ship a copy.
(In reply to comment #3) > That sounds really suboptimal. If pygobject and gjs want to use innards of glib > tests, the should ship a copy. Yeah, the current situation is...awkward. Hmm. Honestly I'd rather work on installed tests than try to incrementally improve the current situation, so...let's go with dieterv's patch from bug 697669.
(In reply to comment #1) > Review of attachment 241061 [details] [review]: > > Thanks for the patch! You're right the developers are busy =) OK. :-) > Wouldn't it be simpler to just do in Makefile.am: > > if ENABLE_TESTS > SUBDIRS += tests > endif We can implement --disable-tests by the approach. Different between the approach and the attached patch approach is occurred in "make dist". The approach doesn't put tests directory into tar.xz. The attached patch approach puts tests directory into tar.xz. You can run "make check" with tar.xz that is created by "./configure --disable-tests --enable-gtk-doc && make && make dist". If we require "--enable-tests" (it is the default) for "make dist", the approach is reasonable.
(In reply to comment #5) > (In reply to comment #1) > > Review of attachment 241061 [details] [review] [details]: > > > > Thanks for the patch! You're right the developers are busy =) > > OK. :-) > > > Wouldn't it be simpler to just do in Makefile.am: > > > > if ENABLE_TESTS > > SUBDIRS += tests > > endif > > We can implement --disable-tests by the approach. > Different between the approach and the attached patch approach is occurred in > "make dist". The approach doesn't put tests directory into tar.xz. The attached > patch approach puts tests directory into tar.xz. you can use DIST_SUBDIRS for that, e.g.: if ENABLE_TESTS SUBDIRS += tests endif DIST_SUBDIRS += tests
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gobject-introspection/issues/84.