After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697642 - g-ir-scanner doesn't generate ".exe" extension
g-ir-scanner doesn't generate ".exe" extension
Status: RESOLVED DUPLICATE of bug 724884
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-09 14:35 UTC by Kouhei Sutou
Modified: 2015-02-07 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix a typo (671 bytes, patch)
2013-04-09 14:35 UTC, Kouhei Sutou 		none Details | Review

Description Kouhei Sutou 2013-04-09 14:35:48 UTC 
Created attachment 241059 [details] [review]
Fix a typo

I read giscanner/dumper.py and noticed that the script has a typo. (I didn't try it on Windows. Sorry.)

Here is a target code:

...
        if os.name == 'nt':
            ext = 'exe'
        else:
            ext = ''

        bin_path = self._generate_tempfile(tmpdir, ext)
...
    def _generate_tempfile(self, tmpdir, suffix=''):
        tmpl = '%s-%s%s' % (self._options.namespace_name,
                            self._options.namespace_version, suffix)
...

_generate_tempfile() uses suffix without extension suffix "." but caller just passes "exe" not ".exe".

Here is a code in the same file:

...
        if self._pkgconfig_msvc_flags:
            o_path = self._generate_tempfile(tmpdir, '.obj')
        else:
            o_path = self._generate_tempfile(tmpdir, '.o')
...

They pass ".".
Comment 1 Fan, Chun-wei 2013-05-28 04:30:29 UTC 
Hi Kouhei,

I think it does make sense to have a '.exe' extension for the dumper program that is built during the creation of the .gir files-however just FYI that script is able to be run without problems even with a Visual Studio build of G-I (including the .gir files, of course).

Might want to ask the G-I maintainers to see whether we can get this in though, to make things more consistent on Windows.

Thanks for the notes.  With blessings.
Comment 2 Simon Feltman 2014-05-07 07:53:48 UTC 

*** This bug has been marked as a duplicate of bug 724884 ***
Comment 3 André Klapper 2015-02-07 16:54:11 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]