After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697625 - giscanner: only parse GTK-Doc comment blocks, ignore the rest
giscanner: only parse GTK-Doc comment blocks, ignore the rest
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-09 09:27 UTC by Dieter Verfaillie
Modified: 2015-02-07 17:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giscanner: only parse GTK-Doc comment blocks, ignore the rest (2.43 KB, patch)
2013-04-09 09:28 UTC, Dieter Verfaillie 		committed Details | Review

Description Dieter Verfaillie 2013-04-09 09:27:14 UTC 
For example, GTK+ has over 15.000 comment blocks (/* ... */)
of which only about 5.000 are GTK-Doc comment blocks (/** ... */).

No need to store and parse those +-10.000 comment blocks
just to find out we don't care about them anyway.
Comment 1 Dieter Verfaillie 2013-04-09 09:28:19 UTC 
Created attachment 241041 [details] [review]
giscanner: only parse GTK-Doc comment blocks, ignore the rest
Comment 2 Colin Walters 2013-04-09 14:19:33 UTC 
Review of attachment 241041 [details] [review]:

Good catch, yes.
Comment 3 Dieter Verfaillie 2013-04-09 21:36:05 UTC 
Comment on attachment 241041 [details] [review]
giscanner: only parse GTK-Doc comment blocks, ignore the rest

Committed, thanks for the review!
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-04-11 15:46:18 UTC 
Is there any way to use lex to parse the comment rather than custom code like this?
Comment 5 Dieter Verfaillie 2013-04-12 09:18:22 UTC 
(In reply to comment #4)
> Is there any way to use lex to parse the comment rather than custom code like
> this?

Not sure it can be done without breaking
https://git.gnome.org/browse/gobject-introspection/tree/giscanner/scannerlexer.l?id=c0e748e1cdf8cf0803266f94c3c5ad154df504a8#n80 ?

Uhm, looking at that, parse_trigraph() does not parse trigraphs but
GTK-Doc stuct field/enum value (private, public) and glib-mkenums (flags)
"annotations"... Also, the "protected" alias for "private" is missing: 
https://git.gnome.org/browse/gtk-doc/tree/gtkdoc-mkdb.in?id=8972559fcaafd05ebad7284790d20c33ff316181#n1506
Comment 6 André Klapper 2015-02-07 17:02:38 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]