After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697623 - giscanner: emit 'incorrect number of parameters in comment block' warning
giscanner: emit 'incorrect number of parameters in comment block' warning
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-09 09:22 UTC by Dieter Verfaillie
Modified: 2015-02-07 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giscanner: emit 'incorrect number of parameters in comment block' warning (2.61 KB, patch)
2013-04-09 09:23 UTC, Dieter Verfaillie 		reviewed Details | Review

Description Dieter Verfaillie 2013-04-09 09:22:49 UTC 
instead of silently ignoring parameter names on signals when the
number of parameters doesn't match our expectations.
Comment 1 Dieter Verfaillie 2013-04-09 09:23:58 UTC 
Created attachment 241039 [details] [review]
giscanner: emit 'incorrect number of parameters in comment block' warning
Comment 2 Colin Walters 2013-04-09 14:11:57 UTC 
Review of attachment 241039 [details] [review]:

Ideally this one would emit a warning, but I guess we can't do that with tests/warn due to the fact there's no library.  

Add something to tests/scanner/WarnLib instead?  Maybe we can later figure out how to test for warnings from that.

Code looks fine.
Comment 3 Colin Walters 2013-05-07 21:34:10 UTC 
Feel free to commit this as is as well.
Comment 5 André Klapper 2015-02-07 16:59:02 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]