After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697621 - giscanner: make _pass_fixup_hidden_fields() more readable
giscanner: make _pass_fixup_hidden_fields() more readable
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-09 09:17 UTC by Dieter Verfaillie
Modified: 2015-02-07 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
giscanner: make _pass_fixup_hidden_fields() more readable (1.54 KB, patch)
2013-04-09 09:18 UTC, Dieter Verfaillie
committed Details | Review

Description Dieter Verfaillie 2013-04-09 09:17:35 UTC
Patch following shortly...
Comment 1 Dieter Verfaillie 2013-04-09 09:18:45 UTC
Created attachment 241036 [details] [review]
giscanner: make _pass_fixup_hidden_fields() more readable
Comment 2 Colin Walters 2013-04-09 13:57:41 UTC
Review of attachment 241036 [details] [review]:

As a general rule I do like to have early exits rather than deeply nested conditionals, but in this particular case we avoid having two exit paths, which is fine.
Comment 3 Dieter Verfaillie 2013-04-09 21:34:49 UTC
Comment on attachment 241036 [details] [review]
giscanner: make _pass_fixup_hidden_fields() more readable

Committed, thanks for the review!
Comment 4 André Klapper 2015-02-07 16:50:18 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]