After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697616 - giscanner: prefer "except X as e" over "except X, e"
giscanner: prefer "except X as e" over "except X, e"
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-09 08:23 UTC by Dieter Verfaillie
Modified: 2015-02-07 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giscanner: prefer "except X as e" over "except X, e" (12.74 KB, patch)
2013-04-09 08:24 UTC, Dieter Verfaillie 		none Details | Review
giscanner: prefer "except X as e" over "except X, e" (12.79 KB, patch)
2013-04-09 09:10 UTC, Dieter Verfaillie 		committed Details | Review

Description Dieter Verfaillie 2013-04-09 08:23:16 UTC 
It's more readable and as an added bonus Python 3 compatible.
Comment 1 Dieter Verfaillie 2013-04-09 08:24:24 UTC 
Created attachment 241020 [details] [review]
giscanner: prefer "except X as e" over "except X, e"
Comment 2 Dieter Verfaillie 2013-04-09 09:10:28 UTC 
Created attachment 241032 [details] [review]
giscanner: prefer "except X as e" over "except X, e"

Forgot to add bug link to commit message...
Comment 3 Colin Walters 2013-04-09 13:43:27 UTC 
Review of attachment 241032 [details] [review]:

Looks good.
Comment 4 Dieter Verfaillie 2013-04-09 21:27:35 UTC 
Comment on attachment 241032 [details] [review]
giscanner: prefer "except X as e" over "except X, e"

Committed, thanks for the review!
Comment 5 André Klapper 2015-02-07 16:51:38 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]