GNOME Bugzilla – Bug 697591
Grid/List view must be in the toolbar, and not in the application menu, for coherence with nautilus
Last modified: 2014-01-08 17:23:40 UTC
It is confusing that the grid/list options in Documents are in the application menu and not in the toolbar like in nautilus.
I spoke with aday about this and he was OK with making this consistent with Nautilus.
Created attachment 264798 [details] [review] mainToolbar: Add Grid/List view toggle buttons to the toolbar Couple of questions: 1. Do we retain the entries in the application menu? 2. Do we show the toggle buttons in the toolbar in the selection mode? Currently you can change the view while being in the selection mode from the application menu.
I noticed that, unlike Nautilus, Bijiben only shows one button.
(In reply to comment #2) > Created an attachment (id=264798) [details] [review] > mainToolbar: Add Grid/List view toggle buttons to the toolbar > > Couple of questions: > > 1. Do we retain the entries in the application menu? I wouldn't. As mentioned on IRC, having these items in the app menu is problematic, since they relate only to the grid/list view, and don't have a visible effect if a document is being viewed. > 2. Do we show the toggle buttons in the toolbar in the selection mode? > Currently you can change the view while being in the selection mode from the > application menu. That doesn't seem necessary - you should already be in your preferred view before entering selection mode.
(In reply to comment #3) > I noticed that, unlike Nautilus, Bijiben only shows one button. There are three options that I can think of: 1. Two toggle buttons. 2. Single toggle button (like in Bijiben). 3. Radio buttons in a gear menu. 1 is probably out - it will make the header bar pretty unbalanced - so it's a choice between 2 and 3. Since it could be odd to have a menu with two radio options in it, option 2 might be best.
Created attachment 265703 [details] [review] mainToolbar: Add a button to toggle Grid/List view
Created attachment 265704 [details] [review] app-menu: Remove the Grid/List items
Is this the desired design? Nautilus always has both buttons visible instead of hiding the one that matches the current view.
Sorry, ignore my last comment - I just saw Allan's comment above.
Comment on attachment 265703 [details] [review] mainToolbar: Add a button to toggle Grid/List view This looks good to me, but we should probably move away from GdHeaderButtons soon. I think GtkButton these days already applies the same style we need.
Comment on attachment 265704 [details] [review] app-menu: Remove the Grid/List items Looks good
Thanks for the review, Cosimo!
(In reply to comment #10) > (From update of attachment 265703 [details] [review]) > This looks good to me, but we should probably move away from GdHeaderButtons > soon. I think GtkButton these days already applies the same style we need. Yes, we should. It would also let us drop "header-bar" from LIBGD_INIT. I will write a patch.