GNOME Bugzilla – Bug 697567
Critical Assertion Errors
Last modified: 2016-12-13 23:30:36 UTC
While testing rhythmbox-2.99-1.fc19 in response to https://bugzilla.redhat.com/show_bug.cgi?id=908540 I encountered several critical errors just opening and closing the application: [local@fedora19] # rhythmbox (rhythmbox:1804): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed (rhythmbox:1804): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed (rhythmbox:1804): Gtk-WARNING **: mnemonic "s" wasn't removed for widget (0x23d48c0) [local@fedora19] #
Hi, i'm ArchLinux with Rhythmbox 3.3 and also geht this error: Gtk-WARNING **: mnemonic "s" wasn't removed for widget (0x282e6e0)
Created attachment 341015 [details] [review] Removes mnemonic from search entry on quit Fixes mnemonic "s" wasn't removed for widget.
Created attachment 341016 [details] [review] source: Use rhythmdb_query_free for RhythmDBQuery, as it is a GPtrArray ( not GObject ) Fixes - g_object_unref: assertion 'G_IS_OBJECT (object)' failed
Created attachment 341060 [details] [review] Removes mnemonic from search entry on quit Added (transfer none)
Review of attachment 341016 [details] [review]: . ::: sources/rb-browser-source.c @@ +210,3 @@ + if (source->priv->search_query != NULL) { + rhythmdb_query_free (source->priv->search_query); + source->priv->search_query = NULL; why not g_clear_pointer (&source->priv->search_query, rhythmdb_query_free) ?
Review of attachment 341060 [details] [review]: I really don't like how this works.
Created attachment 341792 [details] [review] source: Use rhythmdb_query_free for RhythmDBQuery, as it is a GPtrArray ( not GObject )
Created attachment 341793 [details] [review] Removes mnemonic from search entry on quit
Review of attachment 341793 [details] [review]: this is far too much work to do just to fix a single warning that happens on exit.
That was the reason for "attachment 341060 [details] [review]".
Review of attachment 341792 [details] [review]: pushed as commit e8e8a90 with a better commit message
(In reply to vrishab from comment #10) > That was the reason for "attachment 341060 [details] [review] [review]". diff --git a/shell/rb-shell.c b/shell/rb-shell.c index 555e0ee..7ae0227 100644 --- a/shell/rb-shell.c +++ b/shell/rb-shell.c @@ -2518,6 +2518,9 @@ rb_shell_quit (RBShell *shell, /* or maybe just _quit */ /* g_application_release (G_APPLICATION (shell->priv->application)); */ + /* deselect the current page so it drops mnemonics etc. */ + rb_display_page_deselected (shell->priv->selected_page); + rb_settings_delayed_sync (shell->priv->settings, NULL, NULL, NULL); gtk_widget_destroy (GTK_WIDGET (shell->priv->window)); Better patch.
Patch ref: https://git.gnome.org/browse/rhythmbox/commit/?id=921b95144a1edb7244514d7b331e3a9dee157f63