After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697560 - shellEntry: Remove close method
shellEntry: Remove close method
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-08 14:21 UTC by Rui Matos
Modified: 2013-04-08 19:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shellEntry: Remove close method (1.18 KB, patch)
2013-04-08 14:21 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-04-08 14:21:35 UTC 
Fixes a critical

(lt-gnome-shell-real:26033): Clutter-CRITICAL **: clutter_actor_grab_key_focus: assertion `CLUTTER_IS_ACTOR (self)' failed

with the following trace:

0 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/shellEntry.js:86
1 wrapper()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/lang.js:213
2 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/popupMenu.js:1160
3 wrapper()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/lang.js:213
4 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/shellEntry.js:176
5 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/modalDialog.js:116
6 wrapper()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/lang.js:213
7 _parent()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/lang.js:175
8 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/unlockDialog.js:313
9 wrapper()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/lang.js:213
10 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/screenShield.js:1029
11 wrapper()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/lang.js:213
12 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/screenShield.js:954
13 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/tweener.js:113
14 _callOnFunction()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/tweener/tweener.js:202
15 _updateTweenByIndex()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/tweener/tweener.js:332
16 _updateTweens()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/tweener/tweener.js:344
17 _onEnterFrame()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/tweener/tweener.js:359
18 _emit("name" = undefined, "handlers" = undefined, "i" = undefined, "length" = undefined, "arg_array" = undefined, "arguments" = undefined)@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/signals.js:124
19 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/tweener.js:253
20 wrapper()@/home/rmatos/Source/git.gnome.org/install/share/gjs-1.0/lang.js:213
21 anonymous()@/home/rmatos/Source/git.gnome.org/gnome-shell/js/ui/tweener.js:228
Comment 1 Rui Matos 2013-04-08 14:21:38 UTC 
Created attachment 240951 [details] [review]
shellEntry: Remove close method

GrabHelper already takes care of putting the key focus back on the
widget that had it when the grab was established.

ShellEntry's close() has recently become harmful since it's now called
from the menu's destroy() method and that is called in the entry's
destroy handler which means that this._entry might no longer be valid
at close() time.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-04-08 16:58:46 UTC 
Review of attachment 240951 [details] [review]:

OK.
Comment 3 Rui Matos 2013-04-08 19:30:50 UTC 
Attachment 240951 [details] pushed as 07053c3 - shellEntry: Remove close method