After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697495 - window-list: Fix preferences radio buttons not reflecting the setting
window-list: Fix preferences radio buttons not reflecting the setting
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-07 16:01 UTC by Rui Matos
Modified: 2013-04-07 19:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-list: Fix preferences radio buttons not reflecting the setting (1.34 KB, patch)
2013-04-07 16:02 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-04-07 16:01:01 UTC 
The preferences radio buttons always come up with the first one active
regardless of the setting value.
Comment 1 Rui Matos 2013-04-07 16:02:12 UTC 
Created attachment 240890 [details] [review]
window-list: Fix preferences radio buttons not reflecting the setting

When setting GtkRadioButton's group property, its active property is
also set as a by-product. This means that setting these properties
isn't commutative which arguably is a bug in gtk+ but one that we can
easily work around by just switching the order here.
Comment 2 Florian Müllner 2013-04-07 17:40:25 UTC 
Review of attachment 240890 [details] [review]:

Ugh. This GTK+ behavior looks like very black magic to me indeed ... still, the fix is good, so please push!
Comment 3 Rui Matos 2013-04-07 19:02:58 UTC 
(In reply to comment #2)
> Ugh. This GTK+ behavior looks like very black magic to me indeed ... still, the
> fix is good, so please push!

Yes, for the record, here's where the "magic" happens:
https://git.gnome.org/browse/gtk+/tree/gtk/gtkradiobutton.c#n345

Attachment 240890 [details] pushed as 6adeed4 - window-list: Fix preferences radio buttons not reflecting the setting