After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697482 - Use a .ui file for the menu
Use a .ui file for the menu
Status: RESOLVED FIXED
Product: gnome-mahjongg
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-mahjongg-maint
gnome-mahjongg-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-07 13:03 UTC by Paolo Borelli
Modified: 2013-08-19 04:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (6.54 KB, patch)
2013-04-07 13:08 UTC, Paolo Borelli 		committed Details | Review

Description Paolo Borelli 2013-04-07 13:03:59 UTC 
This is more in line with the gnome best practices.

I also fixes the fact that set_app_menu should be called in Application::startup.
Comment 1 Paolo Borelli 2013-04-07 13:08:55 UTC 
Created attachment 240880 [details] [review]
patch
Comment 2 Michael Catanzaro 2013-08-18 15:40:18 UTC 
Review of attachment 240880 [details] [review]:

Sorry for the delay.

Is it really necessary to use a gresource for just the app menu?  I guess I don't really see the benefit to doing that.  Definitely nice to have it in a .ui file, though.

Feel free to push.
Comment 3 Paolo Borelli 2013-08-18 17:30:05 UTC 
(In reply to comment #2)
> Is it really necessary to use a gresource for just the app menu?  I guess I
> don't really see the benefit to doing that.

It is not strictly necessary, but that's part of the best practices and getting the infrastructure in should be a good stepping stone to use it in further cleanups (use an ui files for the window structure and dialogs and put it in the resources). Maybe themes should be resources too.


Anyway pushed