Bug 697433 - file browser: allow me to type a folder path directly
file browser: allow me to type a folder path directly
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: plugins
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Gedit maintainers
Gedit maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-04-06 14:40 UTC by Adam Dingle
Modified: 2013-06-16 12:45 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug 697433 - Allow directly typing a path in file browser (9.25 KB, patch)
2013-06-16 11:15 UTC, Garrett Regier 		reviewed Details | Diff | Review
Bug 697433 - Allow directly typing a path in file browser v2 (9.25 KB, patch)
2013-06-16 11:43 UTC, Garrett Regier 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Adam Dingle 2013-04-06 14:40:13 UTC 
Sometimes it's convenient to be able to navigate to a folder by typing its absolute path directly.  In Nautilus, I can do this by simply typing the path: as soon as I type '/', the path bar is replaced by a text entry box where I can type a folder name.  It would be nice to offer the same in the gedit file browser, where we could replace the combo box with a text box in the same situation.
Comment 1 Paolo Borelli 2013-06-16 08:39:05 UTC 
I am not sure if a text entry works there since it would be a bit crammed, but I agree that it would be nice to have this functionality.

Let's try and if a text entry does not feel ok, we can think of alternatives
Comment 2 Garrett Regier 2013-06-16 08:41:57 UTC 
We could keep it hidden and only show it on ~, /, \, or Ctrl+L. This is the behavior of the GtkFileChooser.
Comment 3 Adam Dingle 2013-06-16 09:19:13 UTC 
(In reply to comment #2)
> We could keep it hidden and only show it on ~, /, \, or Ctrl+L. This is the
> behavior of the GtkFileChooser.

That sounds right to me.
Comment 4 Paolo Borelli 2013-06-16 09:45:06 UTC 
(In reply to comment #2)
> We could keep it hidden and only show it on ~, /, \, or Ctrl+L. This is the
> behavior of the GtkFileChooser.


Yes definitely, sorry if I was not clear.

I meant that once it is shown, the entry does not have much horizontal space.
Comment 5 Garrett Regier 2013-06-16 11:15:08 UTC 
Created attachment 246936 [details] [review]
Bug 697433 - Allow directly typing a path in file browser

The path can be either absolute, uri, or relative. The entry is initially
hidden and is only displayed when ~, /, \ or Ctrl+L are pressed and
will be hidden if Escape is pressed.
Comment 6 Ignacio Casal Quinteiro (nacho) 2013-06-16 11:30:48 UTC 
Review of attachment 246936 [details] [review]:

One minor issue inline.

::: plugins/filebrowser/gedit-file-browser-widget.c
@@ +1320,3 @@
+static void
+show_location_entry (GeditFileBrowserWidget *obj,
+                     gchar                  *location)

const gchar *
Comment 7 Garrett Regier 2013-06-16 11:43:28 UTC 
Created attachment 246937 [details] [review]
Bug 697433 - Allow directly typing a path in file browser v2

(In reply to comment #6)
> Review of attachment 246936 [details] [review]:
> 
> One minor issue inline.
> 
> ::: plugins/filebrowser/gedit-file-browser-widget.c
> @@ +1320,3 @@
> +static void
> +show_location_entry (GeditFileBrowserWidget *obj,
> +                     gchar                  *location)
> 
> const gchar *

Fixed
Comment 8 Ignacio Casal Quinteiro (nacho) 2013-06-16 12:43:21 UTC 
Review of attachment 246937 [details] [review]:

Looks good to me
Comment 9 Garrett Regier 2013-06-16 12:45:37 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Note You need to log in before you can comment on or make changes to this bug.