After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697320 - Emblems break text file preview in icon
Emblems break text file preview in icon
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: Thumbnails
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on: 762871
Blocks:
 
 
Reported: 2013-04-05 10:14 UTC by Tomáš Hnyk
Modified: 2019-09-22 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tomáš Hnyk 2013-04-05 10:14:06 UTC
First reported here: https://bugs.launchpad.net/hundredpapercuts/+bug/899793

Emblems (as used by Ubuntu One) break live preview of text files so instead of showing the first characters of several first lines of a text file, they show a blank icon (with the emblem over it).

This feature is useful as it allows to distinguish several text files one from another (when the filename is not so helpful).

Steps to reproduce:
1. Create a text file and write something to its first line
2. Give the file a nautilus Emblem (that might be tricky, as it is only supported in a programable way now).

What happens:
1. Emblem is shown, live text preview is not shown.

What should happens:
1. Both emblem and live text preview should be shown.
Comment 1 Alexandre Franke 2016-12-11 11:05:35 UTC
Text files seem to have a generic icon now and preview is apparently gone.
Comment 2 Tomáš Hnyk 2016-12-11 11:22:31 UTC
A great way to solve bugs by removing useful features. A bug report calling to bring that functionality back: https://bugzilla.gnome.org/show_bug.cgi?id=762871
Comment 3 Carlos Soriano 2016-12-11 14:03:43 UTC
Previews of text files is wanted, not sure why it doesn't work though.
Comment 4 Alexandre Franke 2016-12-11 17:57:55 UTC
(In reply to Tomáš Hnyk from comment #2)
> A great way to solve bugs by removing useful features.

No need to be passive aggressive.

Let's try to be constructive instead: text files are not the only kind of files that have a preview, so I guess emblems hinder visibility of any file with thumbnails. Therefore I'm making this report more generic and renaming it. I'm also adding the ui-review keyword so that design can review this and provide guidance.
Comment 5 Tomáš Hnyk 2016-12-11 18:14:36 UTC
Sorry, I thought it was intentional removal.

However, now I think you mix up two issues:

1) This bug, that is that text preview is not shown with files with emblems (actually, this is a sub bug of the larger bug of no text preview even without emblems, again see the bug 762871 I linked in comment 2)

2) A more general issue that emblems cover part of the thumbnail (thumbnailing with for example pdf files still works on my machine). Personally, I don't think this is an issue at all.
Comment 6 Carlos Soriano 2016-12-11 18:20:22 UTC
Just a clarification, being the removal on pourpose or not is not a reason to be or not passive-aggressive. So please keep it it a nice way.
Comment 7 Tomáš Hnyk 2016-12-11 18:33:28 UTC
Yes, you are right, I should have said something along the lines of "I am sorry you have removed a feature that used to be useful to me." and I apologize for that. On the other hand, I am not sure that has ever made many useful features of Nautilus reappear (I still miss dual-panel after all those years, among others). I know frustration is no excuse, but I am frustrated by the applications I am using sometimes going backwards (intentionally, as far as I can tell).
Comment 8 Alexandre Franke 2016-12-11 18:56:11 UTC
(In reply to Tomáš Hnyk from comment #5)
> However, now I think you mix up two issues:
> 
> 1) This bug, that is that text preview is not shown with files with emblems
> (actually, this is a sub bug of the larger bug of no text preview even
> without emblems, again see the bug 762871 I linked in comment 2)

Fair enough. I didn't realise that breaking actually meant breaking here. :-)

You're right, let's bring this report back to that specific problem.

Given that preview of text files is completely (i.e. whether there are emblems or not) broken now, how can we observe that emblems do break something and that this is not a duplicate of bug 762871?

> 2) A more general issue that emblems cover part of the thumbnail
> (thumbnailing with for example pdf files still works on my machine).
> Personally, I don't think this is an issue at all.

Right, I was wondering how we could possibly fix that while keeping emblems displayed in a sane manner and after a bit more thought I don't think it is really possible, nor that it really is a problem. Let's forget about that then. :)
Comment 9 Tomáš Hnyk 2016-12-11 19:02:47 UTC
> Given that preview of text files is completely (i.e. whether there are emblems > or not) broken now, how can we observe that emblems do break something and that > this is not a duplicate of bug 762871?

No idea, I guess first bug 762871 must be fixed and then you just need to check if this one gets fixed too or not:-). I added a link in a comment to that bug, I am not sure if there is a more elegant way to link two bugs in Bugzilla.
Comment 10 Alexandre Franke 2016-12-11 19:42:50 UTC
(In reply to Tomáš Hnyk from comment #9)
> I am not sure if there is a more elegant way
> to link two bugs in Bugzilla.

Done (with blocks/depends).

I'm deliberately leaving this as NEEDINFO now, we'll see when 762871 eventually gets fixed.
Comment 11 António Fernandes 2019-09-22 15:45:34 UTC
This bug was specific to the old code that implemented text preview. I don't expect the same code coming back even if the same feature does, so I'm marking this bug as obsolete.