After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697315 - GUPnP-AV-CP might crash if the rescan button is hit after disconnecting from a network
GUPnP-AV-CP might crash if the rescan button is hit after disconnecting from ...
Status: RESOLVED FIXED
Product: gupnp-tools
Classification: Other
Component: General
0.8.x
Other Linux
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-05 09:05 UTC by Mark Ryan
Modified: 2019-02-22 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
av-cp: Avoid possible crash on rescan click (2.72 KB, patch)
2015-11-24 22:17 UTC, Jens Georg 		committed Details | Review

Description Mark Ryan 2013-04-05 09:05:17 UTC 
I haven't actually tested this but looking at the code this is a possibility.  The reason is that it will end up calling gssdp_resource_browser_rescan on an object that no longer exists.

Actually, on IRC it was mentioned that there is no crash and that  gssdp_resource_browser_rescan returns FALSE, but this is probably more luck than anything and if the network goes up and down a number of times we could end up calling gssdp_resource_browser_rescan on a bunch on invalid objects.

There is a bug on GUPnP which calls for a new API to make implementing the rescan feature easier for applications.

https://bugzilla.gnome.org/show_bug.cgi?id=697314

Once 697314 is fixed, fixing this bug should be trivial.
Comment 1 Jens Georg 2015-11-24 22:17:14 UTC 
Created attachment 316206 [details] [review]
av-cp: Avoid possible crash on rescan click

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 2 Jens Georg 2015-11-24 22:17:30 UTC 
Attachment 316206 [details] pushed as f17b6dd - av-cp: Avoid possible crash on rescan click