After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697295 - modalDialog: Destroy dialogs on close
modalDialog: Destroy dialogs on close
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-04 19:04 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-04-05 03:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
modalDialog: Destroy dialogs on close (2.66 KB, patch)
2013-04-04 19:04 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
shellEntry: Destroy entry menus when the entry actors are destroyed (944 bytes, patch)
2013-04-04 19:04 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-04-04 19:04:12 UTC 
See patches for details. I don't know how this one got as far
as it did.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-04-04 19:04:15 UTC 
Created attachment 240652 [details] [review]
modalDialog: Destroy dialogs on close

It turns out that we never destroyed modal dialogs when closing
them, causing them to still linger in the scene graph even when
there were no references to them in the JS. The one case where
we don't want to destroy modal dialogs after being closed is
endSessionDialog, so provide a parameter that allows classes
to override this behavior.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-04-04 19:04:19 UTC 
Created attachment 240653 [details] [review]
shellEntry: Destroy entry menus when the entry actors are destroyed

This ensures that a menu and manager aren't sticking around.
Comment 3 drago01 2013-04-04 19:45:02 UTC 
Review of attachment 240652 [details] [review]:

Good catch.
Comment 4 drago01 2013-04-04 19:45:26 UTC 
Review of attachment 240653 [details] [review]:

Looks good.
Comment 5 drago01 2013-04-04 21:46:06 UTC 
FWIW as those fix leaks I'd say we should get them into 3.8.1
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-04-05 03:15:57 UTC 
Attachment 240652 [details] pushed as 3dd6113 - modalDialog: Destroy dialogs on close
Attachment 240653 [details] pushed as 14189e6 - shellEntry: Destroy entry menus when the entry actors are destroyed


I'm going to assume this is an important enough leak to add to 3.8.1, according to drago01. Please revert and reopen if it's not the case.